All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH v2 net-next] net: ipv6: put host and anycast routes on device with address
Date: Fri, 18 Aug 2017 19:15:31 -0400	[thread overview]
Message-ID: <87wp60lb70.fsf@stressinduktion.org> (raw)
In-Reply-To: <1502997440-32334-1-git-send-email-dsahern@gmail.com> (David Ahern's message of "Thu, 17 Aug 2017 12:17:20 -0700")

Hello David,

David Ahern <dsahern@gmail.com> writes:

> @@ -2688,15 +2716,9 @@ struct rt6_info *addrconf_dst_alloc(struct inet6_dev *idev,
>  {
>  	u32 tb_id;
>  	struct net *net = dev_net(idev->dev);
> -	struct net_device *dev = net->loopback_dev;
> +	struct net_device *dev = idev->dev;
>  	struct rt6_info *rt;
>  
> -	/* use L3 Master device as loopback for host routes if device
> -	 * is enslaved and address is not link local or multicast
> -	 */
> -	if (!rt6_need_strict(addr))
> -		dev = l3mdev_master_dev_rcu(idev->dev) ? : dev;
> -
>  	rt = ip6_dst_alloc(net, dev, DST_NOCOUNT);
>  	if (!rt)
>  		return ERR_PTR(-ENOMEM);

I am afraid this change might break Java:

<http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/65464a307408/src/java.base/unix/native/libnet/net_util_md.c#l574>

I am all in for this change, but maybe it might be necessary to mask
RTF_LOCAL routes with "lo" somehow.

Bye,
Hannes

  reply	other threads:[~2017-08-18 23:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 19:17 [PATCH v2 net-next] net: ipv6: put host and anycast routes on device with address David Ahern
2017-08-18 23:15 ` Hannes Frederic Sowa [this message]
2017-08-19  0:05   ` David Ahern
2017-08-19  0:14     ` David Ahern
2017-08-19  0:28       ` Hannes Frederic Sowa
2017-08-21 13:19         ` David Ahern
2017-08-20  4:53     ` David Miller
2017-08-21 17:41 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp60lb70.fsf@stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.