From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"freenerguo(郭大兴)" <freenerguo@tencent.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-Hsien Lin" <Chi-Hsien.Lin@cypress.com>,
"Wright Feng" <Wright.Feng@cypress.com>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list.pdl@broadcom.com"
<brcm80211-dev-list.pdl@broadcom.com>,
brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
"security@kernel.org" <security@kernel.org>
Subject: Re: [PATCH] brcmfmac: buffer overflow in brcmf_cfg80211_mgmt_tx()
Date: Fri, 07 Jul 2017 11:41:46 +0300 [thread overview]
Message-ID: <87wp7kd4fp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <37617809-d840-fe43-ae0d-71c545f9fab1@broadcom.com> (Arend van Spriel's message of "Fri, 7 Jul 2017 10:28:29 +0200")
Arend van Spriel <arend.vanspriel@broadcom.com> writes:
> On 7/7/2017 12:32 AM, Linus Torvalds wrote:
>> On Thu, Jul 6, 2017 at 10:11 AM, Arend van Spriel
>> <arend.vanspriel@broadcom.com> wrote:
>>>
>>> Looks fine to me so ...
>>
>> I really think that if we can't trust 'len', then we have to check
>> against the lower bound of DOT11_MGMT_HDR_LEN too, because otherwise
>> we'll just have a big 16-bit number instead.
>
> Fair enough. The firmware on the device should have a check in place,
> but guess what... :-( Anyway, the lower bound depends on the type of
> management frames. So for action frames it is DOT11_MGMT_HDR_LEN + 1
> /* Action Category */ + 1 /* Action */.
>
> Might be better to place the lower bound check in
> net/wireless/nl80211.c and do that appropriate for the type of
> management frame. That way it is assured for all wireless drivers.
So I drop this patch and wait for v2?
--
Kalle Valo
next prev parent reply other threads:[~2017-07-07 8:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <88f27bfd328f4ccdb0d6b7ff7e710819@MWHPR06MB3230.namprd06.prod.outlook.com>
2017-07-06 17:11 ` [PATCH] brcmfmac: buffer overflow in brcmf_cfg80211_mgmt_tx() Arend van Spriel
2017-07-06 22:32 ` Linus Torvalds
2017-07-07 8:28 ` Arend van Spriel
2017-07-07 8:41 ` Kalle Valo [this message]
2017-07-07 8:40 ` Kalle Valo
2017-07-07 8:49 ` Dan Carpenter
2017-07-07 9:19 ` Arend van Spriel
2017-07-07 8:46 ` Dan Carpenter
2017-07-07 9:24 ` Arend van Spriel
2017-07-07 10:19 ` Dan Carpenter
2017-07-07 11:19 ` Arend van Spriel
2017-07-07 11:21 ` Arend van Spriel
[not found] <76EE61108481FC4BBFFF404FA986AA6719B8EA26@EXMBX-TJ001.tencent.com>
2017-07-06 8:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp7kd4fp.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Chi-Hsien.Lin@cypress.com \
--cc=Wright.Feng@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=dan.carpenter@oracle.com \
--cc=franky.lin@broadcom.com \
--cc=freenerguo@tencent.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=rafal@milecki.pl \
--cc=security@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.