From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] wildmatch test: cover a blind spot in "/" matching
Date: Sat, 10 Jun 2017 13:31:41 +0200 [thread overview]
Message-ID: <87wp8krsde.fsf@gmail.com> (raw)
In-Reply-To: <xmqqh8zo4na3.fsf@gitster.mtv.corp.google.com>
On Sat, Jun 10 2017, Junio C. Hamano jotted:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>> Add a test which covers a blindspot in how these tests should assert
>>> that negated character classes are allowed or not allowed to match "/"
>>> in certain circumstances.
>>
>> Please make this a bit more explicit, something like
>>
>> A negated character class that does not include '/',
>> e.g. [^a-z],
>
> oops. I think the class includes '/'; please excuse loose logic in
> a "something like" meant as an illustration to show the level of
> details expected ;-)
Thanks for the feedback. Sorry I'm slightly confused still (after
reading this over a couple of times), are you OK with this patch/commit
message as-is or would you still like some clarification there?
prev parent reply other threads:[~2017-06-10 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 9:13 [PATCH] wildmatch test: cover a blind spot in "/" matching Ævar Arnfjörð Bjarmason
2017-06-09 16:21 ` Ævar Arnfjörð Bjarmason
2017-06-10 1:55 ` Junio C Hamano
2017-06-10 1:57 ` Junio C Hamano
2017-06-10 11:31 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp8krsde.fsf@gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.