From: Juan Quintela <quintela@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Jason J . Herne" <jjherne@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 2/3] vmstate: error hint for failed equal checks part 2
Date: Wed, 07 Jun 2017 18:35:51 +0200 [thread overview]
Message-ID: <87wp8ndac8.fsf@secure.mitica> (raw)
In-Reply-To: <20170606165510.33057-3-pasic@linux.vnet.ibm.com> (Halil Pasic's message of "Tue, 6 Jun 2017 18:55:09 +0200")
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL
> so the hint states the assertion probably failed due to a bug. Introduce
> _EQUAL_HINT for specifying a context specific hint.
>
> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> ---
> Keeping this separate for now because we may want something different
> here. E.g. no new macros and adding an extra NULL parameter for all
> pre-existing _EQUAL usages.
I think that the best thing is to just add the HINT always. I checked
and there are only 25 uses of VMSTATE_*_EQUAL. I agree with dave that
adding a NULL there, and make they work is a better strategy.
We are adding 8 new macros so we don't have to change 25 callers?
Later, Juan.
next prev parent reply other threads:[~2017-06-07 16:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 16:55 [Qemu-devel] [RFC PATCH 0/3] vmstate: error hint for failed equal checks Halil Pasic
2017-06-06 16:55 ` [Qemu-devel] [RFC PATCH 1/3] " Halil Pasic
2017-06-07 9:51 ` Dr. David Alan Gilbert
2017-06-08 11:05 ` Halil Pasic
2017-06-14 13:51 ` Halil Pasic
2017-06-22 8:22 ` Dr. David Alan Gilbert
2017-06-22 13:18 ` Halil Pasic
2017-06-22 17:06 ` Dr. David Alan Gilbert
2017-06-29 19:04 ` Eric Blake
2017-06-30 14:41 ` Halil Pasic
2017-06-30 14:54 ` Eric Blake
2017-06-30 16:10 ` Halil Pasic
2017-07-03 13:52 ` Markus Armbruster
2017-07-03 16:21 ` Halil Pasic
2017-07-04 6:42 ` Markus Armbruster
2017-07-04 11:25 ` Halil Pasic
2017-06-06 16:55 ` [Qemu-devel] [RFC PATCH 2/3] vmstate: error hint for failed equal checks part 2 Halil Pasic
2017-06-07 11:07 ` Dr. David Alan Gilbert
2017-06-07 11:30 ` Halil Pasic
2017-06-07 12:01 ` Dr. David Alan Gilbert
2017-06-07 12:19 ` Halil Pasic
2017-06-07 17:10 ` Dr. David Alan Gilbert
2017-06-07 17:18 ` Halil Pasic
2017-06-07 17:21 ` Dr. David Alan Gilbert
2017-06-07 16:35 ` Juan Quintela [this message]
2017-06-07 16:56 ` Halil Pasic
2017-06-06 16:55 ` [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch Halil Pasic
2017-06-07 11:22 ` Dr. David Alan Gilbert
2017-06-07 11:47 ` Halil Pasic
2017-06-07 12:07 ` Dr. David Alan Gilbert
2017-06-07 16:37 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp8ndac8.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.