From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [RFC PATCH 5/7] drm/cec: Add CEC over Aux register definitions Date: Fri, 26 May 2017 11:39:53 +0300 Message-ID: <87wp94m2p2.fsf@intel.com> References: <20170525150626.29748-1-hverkuil@xs4all.nl> <20170525150626.29748-6-hverkuil@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170525150626.29748-6-hverkuil@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil , linux-media@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyNSBNYXkgMjAxNywgSGFucyBWZXJrdWlsIDxodmVya3VpbEB4czRhbGwubmw+IHdy b3RlOgo+IEZyb206IENsaW50IFRheWxvciA8Y2xpbnRvbi5hLnRheWxvckBpbnRlbC5jb20+Cj4K PiBBZGRpbmcgRFBDRCByZWdpc3RlciBkZWZpbml0aW9ucyBmcm9tIHRoZSBEUCAxLjMgc3BlY2lm aWNhdGlvbiBmb3IgQ0VDCj4gb3ZlciBBVVggc3VwcG9ydC4KPgo+IFYyOiBBZGQgRFBfIHByZWZp eCB0byBhbGwgZGVmaW5lcy4KPiBWMzogbWlzc2VkIHByZWZpeGVzIGZyb20gdGhlIEVTSTEgZGVm aW5lcwo+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4K PiBSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBDbGludCBUYXlsb3IgPGNsaW50b24uYS50YXlsb3JAaW50ZWwuY29tPgo+IFNp Z25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gTGluazog aHR0cDovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMTQ5MjcwMzI2My0x MTQ5NC0xLWdpdC1zZW5kLWVtYWlsLWNsaW50b24uYS50YXlsb3JAaW50ZWwuY29tCgpUaGlzIG9u ZSdzIGFscmVhZHkgaW4gZHJtLW5leHQgYXMKCmNvbW1pdCBkNzUzZTQxZDQ3NTQyMTU0M2VhYWVh NWYwZmVhZGJhODI3ZjVmYTAxCkF1dGhvcjogQ2xpbnQgVGF5bG9yIDxjbGludG9uLmEudGF5bG9y QGludGVsLmNvbT4KRGF0ZTogICBUaHUgQXByIDIwIDA4OjQ3OjQzIDIwMTcgLTA3MDAKCiAgICBk cm0vY2VjOiBBZGQgQ0VDIG92ZXIgQXV4IHJlZ2lzdGVyIGRlZmluaXRpb25zCgpCUiwKSmFuaS4K Cgo+IC0tLQo+ICBpbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmggfCA1OSArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDU5IGlu c2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmgg Yi9pbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmgKPiBpbmRleCBjMGJkMGQ3NjUxYTkuLjNmNGFk NzA5NTM0ZSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmgKPiArKysg Yi9pbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmgKPiBAQCAtNjAzLDYgKzYwMyw5IEBACj4gICNk ZWZpbmUgRFBfREVWSUNFX1NFUlZJQ0VfSVJRX1ZFQ1RPUl9FU0kwICAgMHgyMDAzICAgLyogMS4y ICovCj4gIAo+ICAjZGVmaW5lIERQX0RFVklDRV9TRVJWSUNFX0lSUV9WRUNUT1JfRVNJMSAgIDB4 MjAwNCAgIC8qIDEuMiAqLwo+ICsjIGRlZmluZSBEUF9SWF9HVENfTVNUUl9SRVFfU1RBVFVTX0NI QU5HRSAgICAoMSA8PCAwKQo+ICsjIGRlZmluZSBEUF9MT0NLX0FDUVVJU0lUSU9OX1JFUVVFU1Qg ICAgICAgICAoMSA8PCAxKQo+ICsjIGRlZmluZSBEUF9DRUNfSVJRICAgICAgICAgICAgICAgICAg ICAgICAgICAoMSA8PCAyKQo+ICAKPiAgI2RlZmluZSBEUF9MSU5LX1NFUlZJQ0VfSVJRX1ZFQ1RP Ul9FU0kwICAgICAweDIwMDUgICAvKiAxLjIgKi8KPiAgCj4gQEAgLTYzNiw2ICs2MzksNjIgQEAK PiAgIyBkZWZpbmUgRFBfVlNDX0VYVF9DRUFfU0RQX1NVUFBPUlRFRAkJCSgxIDw8IDYpICAvKiBE UCAxLjQgKi8KPiAgIyBkZWZpbmUgRFBfVlNDX0VYVF9DRUFfU0RQX0NIQUlOSU5HX1NVUFBPUlRF RAkJKDEgPDwgNykgIC8qIERQIDEuNCAqLwo+ICAKPiArLyogSERNSSBDRUMgdHVubmVsaW5nIG92 ZXIgQVVYIERQIDEuMyBzZWN0aW9uIDUuMy4zLjMuMSBEUENEIDEuNCsgKi8KPiArI2RlZmluZSBE UF9DRUNfVFVOTkVMSU5HX0NBUEFCSUxJVFkgICAgICAgICAgICAweDMwMDAKPiArIyBkZWZpbmUg RFBfQ0VDX1RVTk5FTElOR19DQVBBQkxFICAgICAgICAgICAgICAgKDEgPDwgMCkKPiArIyBkZWZp bmUgRFBfQ0VDX1NOT09QSU5HX0NBUEFCTEUgICAgICAgICAgICAgICAgKDEgPDwgMSkKPiArIyBk ZWZpbmUgRFBfQ0VDX01VTFRJUExFX0xBX0NBUEFCTEUgICAgICAgICAgICAgKDEgPDwgMikKPiAr Cj4gKyNkZWZpbmUgRFBfQ0VDX1RVTk5FTElOR19DT05UUk9MICAgICAgICAgICAgICAgMHgzMDAx Cj4gKyMgZGVmaW5lIERQX0NFQ19UVU5ORUxJTkdfRU5BQkxFICAgICAgICAgICAgICAgICgxIDw8 IDApCj4gKyMgZGVmaW5lIERQX0NFQ19TTk9PUElOR19FTkFCTEUgICAgICAgICAgICAgICAgICgx IDw8IDEpCj4gKwo+ICsjZGVmaW5lIERQX0NFQ19SWF9NRVNTQUdFX0lORk8gICAgICAgICAgICAg ICAgIDB4MzAwMgo+ICsjIGRlZmluZSBEUF9DRUNfUlhfTUVTU0FHRV9MRU5fTUFTSyAgICAgICAg ICAgICAoMHhmIDw8IDApCj4gKyMgZGVmaW5lIERQX0NFQ19SWF9NRVNTQUdFX0xFTl9TSElGVCAg ICAgICAgICAgIDAKPiArIyBkZWZpbmUgRFBfQ0VDX1JYX01FU1NBR0VfSFBEX1NUQVRFICAgICAg ICAgICAgKDEgPDwgNCkKPiArIyBkZWZpbmUgRFBfQ0VDX1JYX01FU1NBR0VfSFBEX0xPU1QgICAg ICAgICAgICAgKDEgPDwgNSkKPiArIyBkZWZpbmUgRFBfQ0VDX1JYX01FU1NBR0VfQUNLRUQgICAg ICAgICAgICAgICAgKDEgPDwgNikKPiArIyBkZWZpbmUgRFBfQ0VDX1JYX01FU1NBR0VfRU5ERUQg ICAgICAgICAgICAgICAgKDEgPDwgNykKPiArCj4gKyNkZWZpbmUgRFBfQ0VDX1RYX01FU1NBR0Vf SU5GTyAgICAgICAgICAgICAgICAgMHgzMDAzCj4gKyMgZGVmaW5lIERQX0NFQ19UWF9NRVNTQUdF X0xFTl9NQVNLICAgICAgICAgICAgICgweGYgPDwgMCkKPiArIyBkZWZpbmUgRFBfQ0VDX1RYX01F U1NBR0VfTEVOX1NISUZUICAgICAgICAgICAgMAo+ICsjIGRlZmluZSBEUF9DRUNfVFhfUkVUUllf Q09VTlRfTUFTSyAgICAgICAgICAgICAoMHg3IDw8IDQpCj4gKyMgZGVmaW5lIERQX0NFQ19UWF9S RVRSWV9DT1VOVF9TSElGVCAgICAgICAgICAgIDQKPiArIyBkZWZpbmUgRFBfQ0VDX1RYX01FU1NB R0VfU0VORCAgICAgICAgICAgICAgICAgKDEgPDwgNykKPiArCj4gKyNkZWZpbmUgRFBfQ0VDX1RV Tk5FTElOR19JUlFfRkxBR1MgICAgICAgICAgICAgMHgzMDA0Cj4gKyMgZGVmaW5lIERQX0NFQ19S WF9NRVNTQUdFX0lORk9fVkFMSUQgICAgICAgICAgICgxIDw8IDApCj4gKyMgZGVmaW5lIERQX0NF Q19SWF9NRVNTQUdFX09WRVJGTE9XICAgICAgICAgICAgICgxIDw8IDEpCj4gKyMgZGVmaW5lIERQ X0NFQ19UWF9NRVNTQUdFX1NFTlQgICAgICAgICAgICAgICAgICgxIDw8IDQpCj4gKyMgZGVmaW5l IERQX0NFQ19UWF9MSU5FX0VSUk9SICAgICAgICAgICAgICAgICAgICgxIDw8IDUpCj4gKyMgZGVm aW5lIERQX0NFQ19UWF9BRERSRVNTX05BQ0tfRVJST1IgICAgICAgICAgICgxIDw8IDYpCj4gKyMg ZGVmaW5lIERQX0NFQ19UWF9EQVRBX05BQ0tfRVJST1IgICAgICAgICAgICAgICgxIDw8IDcpCj4g Kwo+ICsjZGVmaW5lIERQX0NFQ19MT0dJQ0FMX0FERFJFU1NfTUFTSyAgICAgICAgICAgIDB4MzAw RSAvKiAweDMwMEYgd29yZCAqLwo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNTXzAg ICAgICAgICAgICAgICAoMSA8PCAwKQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNT XzEgICAgICAgICAgICAgICAoMSA8PCAxKQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERS RVNTXzIgICAgICAgICAgICAgICAoMSA8PCAyKQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9B RERSRVNTXzMgICAgICAgICAgICAgICAoMSA8PCAzKQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNB TF9BRERSRVNTXzQgICAgICAgICAgICAgICAoMSA8PCA0KQo+ICsjIGRlZmluZSBEUF9DRUNfTE9H SUNBTF9BRERSRVNTXzUgICAgICAgICAgICAgICAoMSA8PCA1KQo+ICsjIGRlZmluZSBEUF9DRUNf TE9HSUNBTF9BRERSRVNTXzYgICAgICAgICAgICAgICAoMSA8PCA2KQo+ICsjIGRlZmluZSBEUF9D RUNfTE9HSUNBTF9BRERSRVNTXzcgICAgICAgICAgICAgICAoMSA8PCA3KQo+ICsjZGVmaW5lIERQ X0NFQ19MT0dJQ0FMX0FERFJFU1NfTUFTS18yICAgICAgICAgIDB4MzAwRiAvKiAweDMwMEUgd29y ZCAqLwo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNTXzggICAgICAgICAgICAgICAo MSA8PCAwKQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNTXzkgICAgICAgICAgICAg ICAoMSA8PCAxKQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNTXzEwICAgICAgICAg ICAgICAoMSA8PCAyKQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNTXzExICAgICAg ICAgICAgICAoMSA8PCAzKQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNTXzEyICAg ICAgICAgICAgICAoMSA8PCA0KQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNTXzEz ICAgICAgICAgICAgICAoMSA8PCA1KQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERSRVNT XzE0ICAgICAgICAgICAgICAoMSA8PCA2KQo+ICsjIGRlZmluZSBEUF9DRUNfTE9HSUNBTF9BRERS RVNTXzE1ICAgICAgICAgICAgICAoMSA8PCA3KQo+ICsKPiArI2RlZmluZSBEUF9DRUNfUlhfTUVT U0FHRV9CVUZGRVIgICAgICAgICAgICAgICAweDMwMTAKPiArI2RlZmluZSBEUF9DRUNfVFhfTUVT U0FHRV9CVUZGRVIgICAgICAgICAgICAgICAweDMwMjAKPiArI2RlZmluZSBEUF9DRUNfTUVTU0FH RV9CVUZGRVJfTEVOR1RIICAgICAgICAgICAgIDB4MTAKPiArCj4gIC8qIERQIDEuMiBTaWRlYmFu ZCBtZXNzYWdlIGRlZmluZXMgKi8KPiAgLyogcGVlciBkZXZpY2UgdHlwZSAtIERQIDEuMmEgVGFi bGUgMi05MiAqLwo+ICAjZGVmaW5lIERQX1BFRVJfREVWSUNFX05PTkUJCTB4MAoKLS0gCkphbmkg TmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga14.intel.com ([192.55.52.115]:40051 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935733AbdEZIga (ORCPT ); Fri, 26 May 2017 04:36:30 -0400 From: Jani Nikula To: Hans Verkuil , linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Clint Taylor , Daniel Vetter Subject: Re: [RFC PATCH 5/7] drm/cec: Add CEC over Aux register definitions In-Reply-To: <20170525150626.29748-6-hverkuil@xs4all.nl> References: <20170525150626.29748-1-hverkuil@xs4all.nl> <20170525150626.29748-6-hverkuil@xs4all.nl> Date: Fri, 26 May 2017 11:39:53 +0300 Message-ID: <87wp94m2p2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org List-ID: On Thu, 25 May 2017, Hans Verkuil wrote: > From: Clint Taylor > > Adding DPCD register definitions from the DP 1.3 specification for CEC > over AUX support. > > V2: Add DP_ prefix to all defines. > V3: missed prefixes from the ESI1 defines > > Cc: Jani Nikula > > Reviewed-by: Jani Nikula > Signed-off-by: Clint Taylor > Signed-off-by: Jani Nikula > Link: http://patchwork.freedesktop.org/patch/msgid/1492703263-11494-1-git-send-email-clinton.a.taylor@intel.com This one's already in drm-next as commit d753e41d475421543eaaea5f0feadba827f5fa01 Author: Clint Taylor Date: Thu Apr 20 08:47:43 2017 -0700 drm/cec: Add CEC over Aux register definitions BR, Jani. > --- > include/drm/drm_dp_helper.h | 59 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index c0bd0d7651a9..3f4ad709534e 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -603,6 +603,9 @@ > #define DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 0x2003 /* 1.2 */ > > #define DP_DEVICE_SERVICE_IRQ_VECTOR_ESI1 0x2004 /* 1.2 */ > +# define DP_RX_GTC_MSTR_REQ_STATUS_CHANGE (1 << 0) > +# define DP_LOCK_ACQUISITION_REQUEST (1 << 1) > +# define DP_CEC_IRQ (1 << 2) > > #define DP_LINK_SERVICE_IRQ_VECTOR_ESI0 0x2005 /* 1.2 */ > > @@ -636,6 +639,62 @@ > # define DP_VSC_EXT_CEA_SDP_SUPPORTED (1 << 6) /* DP 1.4 */ > # define DP_VSC_EXT_CEA_SDP_CHAINING_SUPPORTED (1 << 7) /* DP 1.4 */ > > +/* HDMI CEC tunneling over AUX DP 1.3 section 5.3.3.3.1 DPCD 1.4+ */ > +#define DP_CEC_TUNNELING_CAPABILITY 0x3000 > +# define DP_CEC_TUNNELING_CAPABLE (1 << 0) > +# define DP_CEC_SNOOPING_CAPABLE (1 << 1) > +# define DP_CEC_MULTIPLE_LA_CAPABLE (1 << 2) > + > +#define DP_CEC_TUNNELING_CONTROL 0x3001 > +# define DP_CEC_TUNNELING_ENABLE (1 << 0) > +# define DP_CEC_SNOOPING_ENABLE (1 << 1) > + > +#define DP_CEC_RX_MESSAGE_INFO 0x3002 > +# define DP_CEC_RX_MESSAGE_LEN_MASK (0xf << 0) > +# define DP_CEC_RX_MESSAGE_LEN_SHIFT 0 > +# define DP_CEC_RX_MESSAGE_HPD_STATE (1 << 4) > +# define DP_CEC_RX_MESSAGE_HPD_LOST (1 << 5) > +# define DP_CEC_RX_MESSAGE_ACKED (1 << 6) > +# define DP_CEC_RX_MESSAGE_ENDED (1 << 7) > + > +#define DP_CEC_TX_MESSAGE_INFO 0x3003 > +# define DP_CEC_TX_MESSAGE_LEN_MASK (0xf << 0) > +# define DP_CEC_TX_MESSAGE_LEN_SHIFT 0 > +# define DP_CEC_TX_RETRY_COUNT_MASK (0x7 << 4) > +# define DP_CEC_TX_RETRY_COUNT_SHIFT 4 > +# define DP_CEC_TX_MESSAGE_SEND (1 << 7) > + > +#define DP_CEC_TUNNELING_IRQ_FLAGS 0x3004 > +# define DP_CEC_RX_MESSAGE_INFO_VALID (1 << 0) > +# define DP_CEC_RX_MESSAGE_OVERFLOW (1 << 1) > +# define DP_CEC_TX_MESSAGE_SENT (1 << 4) > +# define DP_CEC_TX_LINE_ERROR (1 << 5) > +# define DP_CEC_TX_ADDRESS_NACK_ERROR (1 << 6) > +# define DP_CEC_TX_DATA_NACK_ERROR (1 << 7) > + > +#define DP_CEC_LOGICAL_ADDRESS_MASK 0x300E /* 0x300F word */ > +# define DP_CEC_LOGICAL_ADDRESS_0 (1 << 0) > +# define DP_CEC_LOGICAL_ADDRESS_1 (1 << 1) > +# define DP_CEC_LOGICAL_ADDRESS_2 (1 << 2) > +# define DP_CEC_LOGICAL_ADDRESS_3 (1 << 3) > +# define DP_CEC_LOGICAL_ADDRESS_4 (1 << 4) > +# define DP_CEC_LOGICAL_ADDRESS_5 (1 << 5) > +# define DP_CEC_LOGICAL_ADDRESS_6 (1 << 6) > +# define DP_CEC_LOGICAL_ADDRESS_7 (1 << 7) > +#define DP_CEC_LOGICAL_ADDRESS_MASK_2 0x300F /* 0x300E word */ > +# define DP_CEC_LOGICAL_ADDRESS_8 (1 << 0) > +# define DP_CEC_LOGICAL_ADDRESS_9 (1 << 1) > +# define DP_CEC_LOGICAL_ADDRESS_10 (1 << 2) > +# define DP_CEC_LOGICAL_ADDRESS_11 (1 << 3) > +# define DP_CEC_LOGICAL_ADDRESS_12 (1 << 4) > +# define DP_CEC_LOGICAL_ADDRESS_13 (1 << 5) > +# define DP_CEC_LOGICAL_ADDRESS_14 (1 << 6) > +# define DP_CEC_LOGICAL_ADDRESS_15 (1 << 7) > + > +#define DP_CEC_RX_MESSAGE_BUFFER 0x3010 > +#define DP_CEC_TX_MESSAGE_BUFFER 0x3020 > +#define DP_CEC_MESSAGE_BUFFER_LENGTH 0x10 > + > /* DP 1.2 Sideband message defines */ > /* peer device type - DP 1.2a Table 2-92 */ > #define DP_PEER_DEVICE_NONE 0x0 -- Jani Nikula, Intel Open Source Technology Center