From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d83VZ-0002c9-L0 for qemu-devel@nongnu.org; Tue, 09 May 2017 07:40:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d83VT-0004zE-PV for qemu-devel@nongnu.org; Tue, 09 May 2017 07:40:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54828) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d83VT-0004y7-GI for qemu-devel@nongnu.org; Tue, 09 May 2017 07:40:43 -0400 From: Markus Armbruster References: <20170508211953.28017-1-eblake@redhat.com> <20170508211953.28017-3-eblake@redhat.com> Date: Tue, 09 May 2017 13:40:37 +0200 In-Reply-To: <20170508211953.28017-3-eblake@redhat.com> (Eric Blake's message of "Mon, 8 May 2017 16:19:50 -0500") Message-ID: <87wp9qp8ay.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v7 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , Juan Quintela , alistair.francis@xilinx.com, zhanghailiang , "open list:X86" , Anthony Perard , Paolo Bonzini , "Dr. David Alan Gilbert" , Richard Henderson Eric Blake writes: > We want to track why a guest was shutdown; in particular, being able > to tell the difference between a guest request (such as ACPI request) > and host request (such as SIGINT) will prove useful to libvirt. > Since all requests eventually end up changing shutdown_requested in > vl.c, the logical change is to make that value track the reason, > rather than its current 0/1 contents. > > Since command-line options control whether a reset request is turned > into a shutdown request instead, the same treatment is given to > reset_requested. > > This patch adds an internal enum ShutdownCause that describes reasons > that a shutdown can be requested, and changes qemu_system_reset() to > pass the reason through, although for now nothing is actually changed > with regards to what gets reported. The enum could be exported via > QAPI at a later date, if deemed necessary, but for now, there has not > been a request to expose that much detail to end clients. > > For the most part, we turn 0 into SHUTDOWN_CAUSE_NONE, and 1 into > SHUTDOWN_CAUSE_HOST_ERROR; the only specific case where we have enough > information right now to use a different value is when we are reacting > to a host signal. It will take a further patch to edit all call-sites > that can trigger a reset or shutdown request to properly pass in any > other reasons; this patch includes FIXMEs to point such places out. If you need to respin the patch for some other reason, consider replacing FIXME by TODO, because nothing's actually broken here. > > qemu_system_reset() trades its 'bool report' parameter for a > 'ShutdownCause reason', with all non-zero values having the same > effect; this lets us get rid of the weird #defines for VMRESET_* > as synonyms for bools. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH v7 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request Date: Tue, 09 May 2017 13:40:37 +0200 Message-ID: <87wp9qp8ay.fsf@dusky.pond.sub.org> References: <20170508211953.28017-1-eblake@redhat.com> <20170508211953.28017-3-eblake@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d83VV-0003ls-Nl for xen-devel@lists.xenproject.org; Tue, 09 May 2017 11:40:45 +0000 In-Reply-To: <20170508211953.28017-3-eblake@redhat.com> (Eric Blake's message of "Mon, 8 May 2017 16:19:50 -0500") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eric Blake Cc: Stefano Stabellini , Eduardo Habkost , Juan Quintela , "Michael S. Tsirkin" , qemu-devel@nongnu.org, alistair.francis@xilinx.com, Paolo Bonzini , Anthony Perard , "open list:X86" , Richard Henderson , "Dr. David Alan Gilbert" , zhanghailiang List-Id: xen-devel@lists.xenproject.org RXJpYyBCbGFrZSA8ZWJsYWtlQHJlZGhhdC5jb20+IHdyaXRlczoKCj4gV2Ugd2FudCB0byB0cmFj ayB3aHkgYSBndWVzdCB3YXMgc2h1dGRvd247IGluIHBhcnRpY3VsYXIsIGJlaW5nIGFibGUKPiB0 byB0ZWxsIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gYSBndWVzdCByZXF1ZXN0IChzdWNoIGFzIEFD UEkgcmVxdWVzdCkKPiBhbmQgaG9zdCByZXF1ZXN0IChzdWNoIGFzIFNJR0lOVCkgd2lsbCBwcm92 ZSB1c2VmdWwgdG8gbGlidmlydC4KPiBTaW5jZSBhbGwgcmVxdWVzdHMgZXZlbnR1YWxseSBlbmQg dXAgY2hhbmdpbmcgc2h1dGRvd25fcmVxdWVzdGVkIGluCj4gdmwuYywgdGhlIGxvZ2ljYWwgY2hh bmdlIGlzIHRvIG1ha2UgdGhhdCB2YWx1ZSB0cmFjayB0aGUgcmVhc29uLAo+IHJhdGhlciB0aGFu IGl0cyBjdXJyZW50IDAvMSBjb250ZW50cy4KPgo+IFNpbmNlIGNvbW1hbmQtbGluZSBvcHRpb25z IGNvbnRyb2wgd2hldGhlciBhIHJlc2V0IHJlcXVlc3QgaXMgdHVybmVkCj4gaW50byBhIHNodXRk b3duIHJlcXVlc3QgaW5zdGVhZCwgdGhlIHNhbWUgdHJlYXRtZW50IGlzIGdpdmVuIHRvCj4gcmVz ZXRfcmVxdWVzdGVkLgo+Cj4gVGhpcyBwYXRjaCBhZGRzIGFuIGludGVybmFsIGVudW0gU2h1dGRv d25DYXVzZSB0aGF0IGRlc2NyaWJlcyByZWFzb25zCj4gdGhhdCBhIHNodXRkb3duIGNhbiBiZSBy ZXF1ZXN0ZWQsIGFuZCBjaGFuZ2VzIHFlbXVfc3lzdGVtX3Jlc2V0KCkgdG8KPiBwYXNzIHRoZSBy ZWFzb24gdGhyb3VnaCwgYWx0aG91Z2ggZm9yIG5vdyBub3RoaW5nIGlzIGFjdHVhbGx5IGNoYW5n ZWQKPiB3aXRoIHJlZ2FyZHMgdG8gd2hhdCBnZXRzIHJlcG9ydGVkLiAgVGhlIGVudW0gY291bGQg YmUgZXhwb3J0ZWQgdmlhCj4gUUFQSSBhdCBhIGxhdGVyIGRhdGUsIGlmIGRlZW1lZCBuZWNlc3Nh cnksIGJ1dCBmb3Igbm93LCB0aGVyZSBoYXMgbm90Cj4gYmVlbiBhIHJlcXVlc3QgdG8gZXhwb3Nl IHRoYXQgbXVjaCBkZXRhaWwgdG8gZW5kIGNsaWVudHMuCj4KPiBGb3IgdGhlIG1vc3QgcGFydCwg d2UgdHVybiAwIGludG8gU0hVVERPV05fQ0FVU0VfTk9ORSwgYW5kIDEgaW50bwo+IFNIVVRET1dO X0NBVVNFX0hPU1RfRVJST1I7IHRoZSBvbmx5IHNwZWNpZmljIGNhc2Ugd2hlcmUgd2UgaGF2ZSBl bm91Z2gKPiBpbmZvcm1hdGlvbiByaWdodCBub3cgdG8gdXNlIGEgZGlmZmVyZW50IHZhbHVlIGlz IHdoZW4gd2UgYXJlIHJlYWN0aW5nCj4gdG8gYSBob3N0IHNpZ25hbC4gIEl0IHdpbGwgdGFrZSBh IGZ1cnRoZXIgcGF0Y2ggdG8gZWRpdCBhbGwgY2FsbC1zaXRlcwo+IHRoYXQgY2FuIHRyaWdnZXIg YSByZXNldCBvciBzaHV0ZG93biByZXF1ZXN0IHRvIHByb3Blcmx5IHBhc3MgaW4gYW55Cj4gb3Ro ZXIgcmVhc29uczsgdGhpcyBwYXRjaCBpbmNsdWRlcyBGSVhNRXMgdG8gcG9pbnQgc3VjaCBwbGFj ZXMgb3V0LgoKSWYgeW91IG5lZWQgdG8gcmVzcGluIHRoZSBwYXRjaCBmb3Igc29tZSBvdGhlciBy ZWFzb24sIGNvbnNpZGVyCnJlcGxhY2luZyBGSVhNRSBieSBUT0RPLCBiZWNhdXNlIG5vdGhpbmcn cyBhY3R1YWxseSBicm9rZW4gaGVyZS4KCj4KPiBxZW11X3N5c3RlbV9yZXNldCgpIHRyYWRlcyBp dHMgJ2Jvb2wgcmVwb3J0JyBwYXJhbWV0ZXIgZm9yIGEKPiAnU2h1dGRvd25DYXVzZSByZWFzb24n LCB3aXRoIGFsbCBub24temVybyB2YWx1ZXMgaGF2aW5nIHRoZSBzYW1lCj4gZWZmZWN0OyB0aGlz IGxldHMgdXMgZ2V0IHJpZCBvZiB0aGUgd2VpcmQgI2RlZmluZXMgZm9yIFZNUkVTRVRfKgo+IGFz IHN5bm9ueW1zIGZvciBib29scy4KPgo+IFNpZ25lZC1vZmYtYnk6IEVyaWMgQmxha2UgPGVibGFr ZUByZWRoYXQuY29tPgoKUmV2aWV3ZWQtYnk6IE1hcmt1cyBBcm1icnVzdGVyIDxhcm1icnVAcmVk aGF0LmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9s aXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=