From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d848W-0005bA-2g for ath10k@lists.infradead.org; Tue, 09 May 2017 12:21:05 +0000 From: Kalle Valo Subject: Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code Date: Tue, 9 May 2017 12:20:40 +0000 Message-ID: <87wp9qz0fd.fsf@kamboji.qca.qualcomm.com> References: <20170509042159.GA19727@embeddedgus> <87lgq6387s.fsf@kamboji.qca.qualcomm.com> <76408651-07c6-fe31-863f-e1cb73b49663@broadcom.com> In-Reply-To: <76408651-07c6-fe31-863f-e1cb73b49663@broadcom.com> (Arend Van Spriel's message of "Tue, 9 May 2017 14:07:57 +0200") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Arend Van Spriel Cc: "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "Gustavo A. R. Silva" , "linux-kernel@vger.kernel.org" , "ath10k@lists.infradead.org" Arend Van Spriel writes: > On 9-5-2017 7:33, Kalle Valo wrote: >> "Gustavo A. R. Silva" writes: >> >>> The name of an array used by itself will always return the array's address. >>> So these tests will always evaluate as false and therefore the _return_ >>> will never be executed. >>> >>> Signed-off-by: Gustavo A. R. Silva >> >> I don't understand the commit log, especially what does "The name of an >> array used by itself" mean? > > The array fields in struct wmi_start_scan_arg that are checked here are > fixed size arrays so they can never be NULL. > > Maybe that helps rephrasing this commit message. Much much better, thanks! -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:24601 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbdEIMUn (ORCPT ); Tue, 9 May 2017 08:20:43 -0400 From: Kalle Valo To: Arend Van Spriel CC: "Gustavo A. R. Silva" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code Date: Tue, 9 May 2017 12:20:40 +0000 Message-ID: <87wp9qz0fd.fsf@kamboji.qca.qualcomm.com> (sfid-20170509_142123_497725_9A37F9E2) References: <20170509042159.GA19727@embeddedgus> <87lgq6387s.fsf@kamboji.qca.qualcomm.com> <76408651-07c6-fe31-863f-e1cb73b49663@broadcom.com> In-Reply-To: <76408651-07c6-fe31-863f-e1cb73b49663@broadcom.com> (Arend Van Spriel's message of "Tue, 9 May 2017 14:07:57 +0200") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend Van Spriel writes: > On 9-5-2017 7:33, Kalle Valo wrote: >> "Gustavo A. R. Silva" writes: >>=20 >>> The name of an array used by itself will always return the array's addr= ess. >>> So these tests will always evaluate as false and therefore the _return_ >>> will never be executed. >>> >>> Signed-off-by: Gustavo A. R. Silva >>=20 >> I don't understand the commit log, especially what does "The name of an >> array used by itself" mean? > > The array fields in struct wmi_start_scan_arg that are checked here are > fixed size arrays so they can never be NULL. > > Maybe that helps rephrasing this commit message. Much much better, thanks! --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbdEIMUq (ORCPT ); Tue, 9 May 2017 08:20:46 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:24601 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbdEIMUn (ORCPT ); Tue, 9 May 2017 08:20:43 -0400 X-IronPort-AV: E=Sophos;i="5.38,314,1491289200"; d="scan'208";a="380193089" X-IronPort-AV: E=McAfee;i="5800,7501,8522"; a="955741492" X-MGA-submission: =?us-ascii?q?MDFTy57GOwjdTrbiquAJoqC/4SdAeKgAqWzvyU?= =?us-ascii?q?wtH4Ev5e1khNNVxdv7UaDbNfkTBjiXfrki1FID6aEuC/I68bxb4cEQtD?= =?us-ascii?q?6SqC5oeHvTDsafn+8mz88znlKPaHYOz/02axUXgtAbeDi20J1mxsBSVb?= =?us-ascii?q?XD?= From: Kalle Valo To: Arend Van Spriel CC: "Gustavo A. R. Silva" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code Thread-Topic: [PATCH] net: wireless: ath: ath10k: remove unnecessary code Thread-Index: AQHSyL6rtVSx41I1+Ue57FCb5aIdKw== Date: Tue, 9 May 2017 12:20:40 +0000 Message-ID: <87wp9qz0fd.fsf@kamboji.qca.qualcomm.com> References: <20170509042159.GA19727@embeddedgus> <87lgq6387s.fsf@kamboji.qca.qualcomm.com> <76408651-07c6-fe31-863f-e1cb73b49663@broadcom.com> In-Reply-To: <76408651-07c6-fe31-863f-e1cb73b49663@broadcom.com> (Arend Van Spriel's message of "Tue, 9 May 2017 14:07:57 +0200") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v49CKs1e030850 Arend Van Spriel writes: > On 9-5-2017 7:33, Kalle Valo wrote: >> "Gustavo A. R. Silva" writes: >> >>> The name of an array used by itself will always return the array's address. >>> So these tests will always evaluate as false and therefore the _return_ >>> will never be executed. >>> >>> Signed-off-by: Gustavo A. R. Silva >> >> I don't understand the commit log, especially what does "The name of an >> array used by itself" mean? > > The array fields in struct wmi_start_scan_arg that are checked here are > fixed size arrays so they can never be NULL. > > Maybe that helps rephrasing this commit message. Much much better, thanks! -- Kalle Valo