From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxrbj-0006yc-6t for qemu-devel@nongnu.org; Tue, 11 Apr 2017 04:57:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxrbf-00057x-By for qemu-devel@nongnu.org; Tue, 11 Apr 2017 04:57:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25208) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cxrbf-00057n-5m for qemu-devel@nongnu.org; Tue, 11 Apr 2017 04:56:59 -0400 From: Markus Armbruster References: <20170320001249.25521-1-haozhong.zhang@intel.com> <20170320001249.25521-11-haozhong.zhang@intel.com> Date: Tue, 11 Apr 2017 10:56:53 +0200 In-Reply-To: <20170320001249.25521-11-haozhong.zhang@intel.com> (Haozhong Zhang's message of "Mon, 20 Mar 2017 08:12:49 +0800") Message-ID: <87wparcofe.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC QEMU PATCH v2 10/10] qapi: extend 'query-memory-devices' to list devices of specified type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Haozhong Zhang Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org, Xiao Guangrong , "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , Igor Mammedov , Konrad Rzeszutek Wilk , Dan Williams Haozhong Zhang writes: > Add an optional argument 'devtype' to 'query-memory-devices', which > is either 'dimm' or 'nvdimm'. If 'devtype' is missed or 'dimm', all > memory devices will be listed. If 'devtype' is 'nvdimm', only nvdimm > devices will be listed. Basically, the argument provides limited server-side filtering of the output of query-memory-devices. > Signed-off-by: Haozhong Zhang > --- > Cc: "Dr. David Alan Gilbert" > Cc: Xiao Guangrong > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Eric Blake > Cc: Markus Armbruster > --- > hmp.c | 3 +- > hw/mem/nvdimm.c | 38 ++++++++++++++++++++++++++ > hw/mem/pc-dimm.c | 71 ++++++++++++++++++++++++++++-------------------- > include/hw/mem/nvdimm.h | 2 ++ > include/hw/mem/pc-dimm.h | 1 + > qapi-schema.json | 48 +++++++++++++++++++++++++++++--- > qmp.c | 13 +++++++-- > 7 files changed, 140 insertions(+), 36 deletions(-) Why is this server-side filtering worth the additional code and complexity? Why not simply filter in the client? What's your use case? [...] From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [RFC QEMU PATCH v2 10/10] qapi: extend 'query-memory-devices' to list devices of specified type Date: Tue, 11 Apr 2017 10:56:53 +0200 Message-ID: <87wparcofe.fsf@dusky.pond.sub.org> References: <20170320001249.25521-1-haozhong.zhang@intel.com> <20170320001249.25521-11-haozhong.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170320001249.25521-11-haozhong.zhang@intel.com> (Haozhong Zhang's message of "Mon, 20 Mar 2017 08:12:49 +0800") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Haozhong Zhang Cc: Xiao Guangrong , "Michael S. Tsirkin" , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Konrad Rzeszutek Wilk , Igor Mammedov , Dan Williams , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SGFvemhvbmcgWmhhbmcgPGhhb3pob25nLnpoYW5nQGludGVsLmNvbT4gd3JpdGVzOgoKPiBBZGQg YW4gb3B0aW9uYWwgYXJndW1lbnQgJ2RldnR5cGUnIHRvICdxdWVyeS1tZW1vcnktZGV2aWNlcycs IHdoaWNoCj4gaXMgZWl0aGVyICdkaW1tJyBvciAnbnZkaW1tJy4gSWYgJ2RldnR5cGUnIGlzIG1p c3NlZCBvciAnZGltbScsIGFsbAo+IG1lbW9yeSBkZXZpY2VzIHdpbGwgYmUgbGlzdGVkLiBJZiAn ZGV2dHlwZScgaXMgJ252ZGltbScsIG9ubHkgbnZkaW1tCj4gZGV2aWNlcyB3aWxsIGJlIGxpc3Rl ZC4KCkJhc2ljYWxseSwgdGhlIGFyZ3VtZW50IHByb3ZpZGVzIGxpbWl0ZWQgc2VydmVyLXNpZGUg ZmlsdGVyaW5nIG9mIHRoZQpvdXRwdXQgb2YgcXVlcnktbWVtb3J5LWRldmljZXMuCgo+IFNpZ25l ZC1vZmYtYnk6IEhhb3pob25nIFpoYW5nIDxoYW96aG9uZy56aGFuZ0BpbnRlbC5jb20+Cj4gLS0t Cj4gQ2M6ICJEci4gRGF2aWQgQWxhbiBHaWxiZXJ0IiA8ZGdpbGJlcnRAcmVkaGF0LmNvbT4KPiBD YzogWGlhbyBHdWFuZ3JvbmcgPGd1YW5ncm9uZy54aWFvQGxpbnV4LmludGVsLmNvbT4KPiBDYzog Ik1pY2hhZWwgUy4gVHNpcmtpbiIgPG1zdEByZWRoYXQuY29tPgo+IENjOiBJZ29yIE1hbW1lZG92 IDxpbWFtbWVkb0ByZWRoYXQuY29tPgo+IENjOiBFcmljIEJsYWtlIDxlYmxha2VAcmVkaGF0LmNv bT4KPiBDYzogTWFya3VzIEFybWJydXN0ZXIgPGFybWJydUByZWRoYXQuY29tPgo+IC0tLQo+ICBo bXAuYyAgICAgICAgICAgICAgICAgICAgfCAgMyArLQo+ICBody9tZW0vbnZkaW1tLmMgICAgICAg ICAgfCAzOCArKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBody9tZW0vcGMtZGltbS5jICAg ICAgICAgfCA3MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t LS0KPiAgaW5jbHVkZS9ody9tZW0vbnZkaW1tLmggIHwgIDIgKysKPiAgaW5jbHVkZS9ody9tZW0v cGMtZGltbS5oIHwgIDEgKwo+ICBxYXBpLXNjaGVtYS5qc29uICAgICAgICAgfCA0OCArKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLQo+ICBxbXAuYyAgICAgICAgICAgICAgICAgICAgfCAx MyArKysrKysrLS0KPiAgNyBmaWxlcyBjaGFuZ2VkLCAxNDAgaW5zZXJ0aW9ucygrKSwgMzYgZGVs ZXRpb25zKC0pCgpXaHkgaXMgdGhpcyBzZXJ2ZXItc2lkZSBmaWx0ZXJpbmcgd29ydGggdGhlIGFk ZGl0aW9uYWwgY29kZSBhbmQKY29tcGxleGl0eT8gIFdoeSBub3Qgc2ltcGx5IGZpbHRlciBpbiB0 aGUgY2xpZW50PyAgV2hhdCdzIHlvdXIgdXNlIGNhc2U/CgpbLi4uXQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==