From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, rth@twiddle.net,
ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] vmstatification: i386 FPReg
Date: Wed, 05 Apr 2017 21:26:46 +0200 [thread overview]
Message-ID: <87wpay3bbd.fsf@secure.mitica> (raw)
In-Reply-To: <20170405190024.27581-3-dgilbert@redhat.com> (David Alan Gilbert's message of "Wed, 5 Apr 2017 20:00:23 +0100")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Convert the fpreg save/restore to use VMSTATE_ macros rather than
> .get/.put.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
But if you have to respin
> +typedef struct x86_FPReg_tmp {
> + FPReg *parent;
> + uint64_t tmp_mant;
> + uint16_t tmp_exp;
> +} x86_FPReg_tmp;
Too many tmp's? I am pretty sure that you can call the fields mant and exp.
Later, Juan.
next prev parent reply other threads:[~2017-04-05 19:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 19:00 [Qemu-devel] [PATCH 0/3 for 2.10] migration/i386 cleanup Dr. David Alan Gilbert (git)
2017-04-05 19:00 ` [Qemu-devel] [PATCH 1/3] migration/i386: Remove old non-softfloat 64bit FP support Dr. David Alan Gilbert (git)
2017-04-05 19:13 ` Juan Quintela
2017-04-13 15:01 ` Eduardo Habkost
2017-04-18 11:04 ` Dr. David Alan Gilbert
2017-04-05 19:00 ` [Qemu-devel] [PATCH 2/3] vmstatification: i386 FPReg Dr. David Alan Gilbert (git)
2017-04-05 19:26 ` Juan Quintela [this message]
2017-04-13 20:52 ` Eduardo Habkost
2017-04-05 19:00 ` [Qemu-devel] [PATCH 3/3] migration/i386: Remove support for pre-0.12 formats Dr. David Alan Gilbert (git)
2017-04-05 19:29 ` Juan Quintela
2017-04-13 20:51 ` Eduardo Habkost
2017-04-05 19:10 ` [Qemu-devel] [PATCH 0/3 for 2.10] migration/i386 cleanup Juan Quintela
2017-04-13 20:55 ` Eduardo Habkost
2017-04-18 11:00 ` Dr. David Alan Gilbert
2017-04-18 12:30 ` Paolo Bonzini
2017-05-11 17:03 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpay3bbd.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.