From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2 2/3] drm/i915: Assert that the request->tail fits within the ring Date: Mon, 27 Mar 2017 16:57:13 +0300 Message-ID: <87wpbax1om.fsf@gaia.fi.intel.com> References: <20170327130009.4678-1-chris@chris-wilson.co.uk> <20170327130009.4678-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D2D689050 for ; Mon, 27 Mar 2017 13:58:07 +0000 (UTC) In-Reply-To: <20170327130009.4678-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gYWRk aXRpb24gdG8gYmVpbmcgcXdvcmQtYWxpZ25lZCwgdGhlIFJJTkdfVEFJTCBvZmZzZXQgbXVzdCBi ZSB3aXRoaW4KPiB0aGUgcmluZyEKPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hy aXNAY2hyaXMtd2lsc29uLmNvLnVrPgoKUmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eu a3VvcHBhbGFAaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMgICAgICAgIHwgNCArKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuYyB8IDMgKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDMyZmI4YWQzZmQzNi4uMzljYjg0YTVkNGU0 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMzI3LDYgKzMyNyw3IEBAIHN0 YXRpYyB1NjQgZXhlY2xpc3RzX3VwZGF0ZV9jb250ZXh0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVx dWVzdCAqcnEpCj4gIAl1MzIgKnJlZ19zdGF0ZSA9IGNlLT5scmNfcmVnX3N0YXRlOwo+ICAKPiAg CUdFTV9CVUdfT04oIUlTX0FMSUdORUQocnEtPnRhaWwsIDgpKTsKPiArCUdFTV9CVUdfT04ocnEt PnRhaWwgPj0gcnEtPnJpbmctPnNpemUpOwo+ICAJcmVnX3N0YXRlW0NUWF9SSU5HX1RBSUwrMV0g PSBycS0+dGFpbDsKPiAgCj4gIAkvKiBUcnVlIDMyYiBQUEdUVCB3aXRoIGR5bmFtaWMgcGFnZSBh bGxvY2F0aW9uOiB1cGRhdGUgUERQCj4gQEAgLTEyODIsNiArMTI4Myw3IEBAIHN0YXRpYyB2b2lk IHJlc2V0X2NvbW1vbl9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCQlp bnRlbF9yaW5nX3dyYXAocmVxdWVzdC0+cmluZywKPiAgCQkJCXJlcXVlc3QtPndhX3RhaWwgLSBX QV9UQUlMX0RXT1JEUypzaXplb2YodTMyKSk7Cj4gIAlHRU1fQlVHX09OKCFJU19BTElHTkVEKHJl cXVlc3QtPnRhaWwsIDgpKTsKPiArCUdFTV9CVUdfT04ocmVxdWVzdC0+dGFpbCA+PSByZXF1ZXN0 LT5yaW5nLT5zaXplKTsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBpbnRlbF9sb2dpY2FsX3Jpbmdf ZW1pdF9wZHBzKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQo+IEBAIC0xNDkzLDYg KzE0OTUsNyBAQCBzdGF0aWMgdm9pZCBnZW44X2VtaXRfYnJlYWRjcnVtYihzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QsIHUzMiAqY3MpCj4gIAkqY3MrKyA9IE1JX05PT1A7Cj4g IAlyZXF1ZXN0LT50YWlsID0gaW50ZWxfcmluZ19vZmZzZXQocmVxdWVzdCwgY3MpOwo+ICAJR0VN X0JVR19PTighSVNfQUxJR05FRChyZXF1ZXN0LT50YWlsLCA4KSk7Cj4gKwlHRU1fQlVHX09OKHJl cXVlc3QtPnRhaWwgPj0gcmVxdWVzdC0+cmluZy0+c2l6ZSk7Cj4gIAo+ICAJZ2VuOF9lbWl0X3dh X3RhaWwocmVxdWVzdCwgY3MpOwo+ICB9Cj4gQEAgLTE1MjEsNiArMTUyNCw3IEBAIHN0YXRpYyB2 b2lkIGdlbjhfZW1pdF9icmVhZGNydW1iX3JlbmRlcihzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVl c3QgKnJlcXVlc3QsCj4gIAkqY3MrKyA9IE1JX05PT1A7Cj4gIAlyZXF1ZXN0LT50YWlsID0gaW50 ZWxfcmluZ19vZmZzZXQocmVxdWVzdCwgY3MpOwo+ICAJR0VNX0JVR19PTighSVNfQUxJR05FRChy ZXF1ZXN0LT50YWlsLCA4KSk7Cj4gKwlHRU1fQlVHX09OKHJlcXVlc3QtPnRhaWwgPj0gcmVxdWVz dC0+cmluZy0+c2l6ZSk7Cj4gIAo+ICAJZ2VuOF9lbWl0X3dhX3RhaWwocmVxdWVzdCwgY3MpOwo+ ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IDQ3Mjlh YzdhYzEyMi4uNDc5MjFkY2JlZGIzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3JpbmdidWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jp bmdidWZmZXIuYwo+IEBAIC03NzUsNiArNzc1LDcgQEAgc3RhdGljIHZvaWQgaTl4eF9zdWJtaXRf cmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gIAlpOTE1X2dl bV9yZXF1ZXN0X3N1Ym1pdChyZXF1ZXN0KTsKPiAgCj4gIAlHRU1fQlVHX09OKCFJU19BTElHTkVE KHJlcXVlc3QtPnRhaWwsIDgpKTsKPiArCUdFTV9CVUdfT04ocmVxdWVzdC0+dGFpbCA+PSByZXF1 ZXN0LT5yaW5nLT5zaXplKTsKPiAgCUk5MTVfV1JJVEVfVEFJTChyZXF1ZXN0LT5lbmdpbmUsIHJl cXVlc3QtPnRhaWwpOwo+ICB9Cj4gIAo+IEBAIC03ODcsNiArNzg4LDcgQEAgc3RhdGljIHZvaWQg aTl4eF9lbWl0X2JyZWFkY3J1bWIoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEsIHUz MiAqY3MpCj4gIAo+ICAJcmVxLT50YWlsID0gaW50ZWxfcmluZ19vZmZzZXQocmVxLCBjcyk7Cj4g IAlHRU1fQlVHX09OKCFJU19BTElHTkVEKHJlcS0+dGFpbCwgOCkpOwo+ICsJR0VNX0JVR19PTihy ZXEtPnRhaWwgPj0gcmVxLT5yaW5nLT5zaXplKTsKPiAgfQo+ICAKPiAgc3RhdGljIGNvbnN0IGlu dCBpOXh4X2VtaXRfYnJlYWRjcnVtYl9zeiA9IDQ7Cj4gQEAgLTgyNiw2ICs4MjgsNyBAQCBzdGF0 aWMgdm9pZCBnZW44X3JlbmRlcl9lbWl0X2JyZWFkY3J1bWIoc3RydWN0IGRybV9pOTE1X2dlbV9y ZXF1ZXN0ICpyZXEsCj4gIAo+ICAJcmVxLT50YWlsID0gaW50ZWxfcmluZ19vZmZzZXQocmVxLCBj cyk7Cj4gIAlHRU1fQlVHX09OKCFJU19BTElHTkVEKHJlcS0+dGFpbCwgOCkpOwo+ICsJR0VNX0JV R19PTihyZXEtPnRhaWwgPj0gcmVxLT5yaW5nLT5zaXplKTsKPiAgfQo+ICAKPiAgc3RhdGljIGNv bnN0IGludCBnZW44X3JlbmRlcl9lbWl0X2JyZWFkY3J1bWJfc3ogPSA4Owo+IC0tIAo+IDIuMTEu MApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK