From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/3] drivers:gpu: vga :vga_switcheroo.c : Fixed some coding style issues Date: Wed, 01 Mar 2017 11:50:56 +0200 Message-ID: <87wpc9colb.fsf@intel.com> References: <20170301084544.rx5tluo74f3p2x66@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7E306E8E4 for ; Wed, 1 Mar 2017 09:50:59 +0000 (UTC) In-Reply-To: <20170301084544.rx5tluo74f3p2x66@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Joan Jani Cc: "daniel.vetter@intel.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAwMSBNYXIgMjAxNywgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBUdWUsIEZlYiAyOCwgMjAxNyBhdCAwNjo1OTo1MlBNICswMDAwLCBKb2FuIEphbmkg d3JvdGU6Cj4+IEZpeGVkIHRoZSBmb2xsb3dpbmcgc3R5bGUgaXNzdWVzCj4+IAo+PiBkcml2ZXJz L2dwdS92Z2EvdmdhX3N3aXRjaGVyb28uYzo5ODogV0FSTklORzogcGxlYXNlLCBubyBzcGFjZSBi ZWZvcmUgdGFicwo+PiBkcml2ZXJzL2dwdS92Z2EvdmdhX3N3aXRjaGVyb28uYzo5OTogV0FSTklO RzogcGxlYXNlLCBubyBzcGFjZSBiZWZvcmUgdGFicwo+PiBkcml2ZXJzL2dwdS92Z2EvdmdhX3N3 aXRjaGVyb28uYzoxMDI6IFdBUk5JTkc6IHBsZWFzZSwgbm8gc3BhY2UgYmVmb3JlIHRhYnMKPj4g ZHJpdmVycy9ncHUvdmdhL3ZnYV9zd2l0Y2hlcm9vLmM6MTAzOiBXQVJOSU5HOiBwbGVhc2UsIG5v IHNwYWNlIGJlZm9yZSB0YWJzCj4+IGRyaXZlcnMvZ3B1L3ZnYS92Z2Ffc3dpdGNoZXJvby5jOjEy OTogV0FSTklORzogcGxlYXNlLCBubyBzcGFjZSBiZWZvcmUgdGFicwo+PiBkcml2ZXJzL2dwdS92 Z2EvdmdhX3N3aXRjaGVyb28uYzoxMzU6IFdBUk5JTkc6IHBsZWFzZSwgbm8gc3BhY2UgYmVmb3Jl IHRhYnMKPj4gZHJpdmVycy9ncHUvdmdhL3ZnYV9zd2l0Y2hlcm9vLmM6MjE3OiBXQVJOSU5HOiBs aW5lIG92ZXIgODAgY2hhcmFjdGVycwo+PiBkcml2ZXJzL2dwdS92Z2EvdmdhX3N3aXRjaGVyb28u YzoyMTg6IFdBUk5JTkc6IGxpbmUgb3ZlciA4MCBjaGFyYWN0ZXJzCj4+IGRyaXZlcnMvZ3B1L3Zn YS92Z2Ffc3dpdGNoZXJvby5jOjMwODogV0FSTklORzogcGxlYXNlLCBubyBzcGFjZSBiZWZvcmUg dGFicwo+PiBkcml2ZXJzL2dwdS92Z2EvdmdhX3N3aXRjaGVyb28uYzozNDA6IFdBUk5JTkc6IGxp bmUgb3ZlciA4MCBjaGFyYWN0ZXJzCj4+IGRyaXZlcnMvZ3B1L3ZnYS92Z2Ffc3dpdGNoZXJvby5j OjEwODc6IFdBUk5JTkc6IEJsb2NrIGNvbW1lbnRzIHVzZSAqIG9uIHN1YnNlcXVlbnQgbGluZXMK Pj4gZHJpdmVycy9ncHUvdmdhL3ZnYV9zd2l0Y2hlcm9vLmM6MTA4NzogV0FSTklORzogQmxvY2sg Y29tbWVudHMgdXNlIGEgdHJhaWxpbmcgKi8gb24gYSBzZXBhcmF0ZSBsaW5lCj4+IAo+PiBTaWdu ZWQtb2ZmLWJ5OiBKb2FuIEphbmkgPGlnaWFubkBob3RtYWlsLmNvbT4KPgo+IEFwcGxpZWQgdG8g ZHJtLW1pc2MgZm9yIDQuMTIsIHRoYW5rcy4KCkZyYW5rbHksIEkgd2lzaCB5b3UgaGFkbid0LiBU aGUgcGF0Y2ggY2hhbmdlZCB0aGUgcGVyZmVjdGx5IGZpbmU6CgppbnQgdmdhX3N3aXRjaGVyb29f cmVnaXN0ZXJfaGFuZGxlcihjb25zdCBzdHJ1Y3QgdmdhX3N3aXRjaGVyb29faGFuZGxlciAqaGFu ZGxlciwKCQkJCSAgICBlbnVtIHZnYV9zd2l0Y2hlcm9vX2hhbmRsZXJfZmxhZ3NfdCBoYW5kbGVy X2ZsYWdzKQoKaW50byBob3JyZW5kb3VzOgoKaW50IHZnYV9zd2l0Y2hlcm9vX3JlZ2lzdGVyX2hh bmRsZXIoCgkJCSAgY29uc3Qgc3RydWN0IHZnYV9zd2l0Y2hlcm9vX2hhbmRsZXIgKmhhbmRsZXIs CgkJCSAgZW51bSB2Z2Ffc3dpdGNoZXJvb19oYW5kbGVyX2ZsYWdzX3QgaGFuZGxlcl9mbGFncykK Ckp1c3QgdG8gYXBwZWFzZSB0aGUgODAgY29sdW1uIHJ1bGUuIERpdHRvIGZvcgp2Z2Ffc3dpdGNo ZXJvb19yZWdpc3Rlcl9hdWRpb19jbGllbnQuIFRoaXMgaXMgd2h5IHdlIGRvbid0IGdlbmVyYWxs eQp3YW50IHB1cmUgY2hlY2twYXRjaCBmaXhlcyBvbiBleGlzdGluZyBmaWxlcy4gVGhleSBkb24n dCBtYWtlIHRoaW5ncwpiZXR0ZXIuCgpCUiwKSmFuaS4KCgoKPiAtRGFuaWVsCj4KPj4gLS0tCj4+ ICBkcml2ZXJzL2dwdS92Z2EvdmdhX3N3aXRjaGVyb28uYyB8IDI4ICsrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxMyBkZWxl dGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS92Z2EvdmdhX3N3aXRjaGVy b28uYyBiL2RyaXZlcnMvZ3B1L3ZnYS92Z2Ffc3dpdGNoZXJvby5jCj4+IGluZGV4IDVmOTYyYmYu LjNjZDE1M2MgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L3ZnYS92Z2Ffc3dpdGNoZXJvby5j Cj4+ICsrKyBiL2RyaXZlcnMvZ3B1L3ZnYS92Z2Ffc3dpdGNoZXJvby5jCj4+IEBAIC05NSwxMiAr OTUsMTIgQEAKPj4gICAqIEBwd3Jfc3RhdGU6IGN1cnJlbnQgcG93ZXIgc3RhdGUKPj4gICAqIEBv cHM6IGNsaWVudCBjYWxsYmFja3MKPj4gICAqIEBpZDogY2xpZW50IGlkZW50aWZpZXIuIERldGVy bWluaW5nIHRoZSBpZCByZXF1aXJlcyB0aGUgaGFuZGxlciwKPj4gLSAqIAlzbyBncHVzIGFyZSBp bml0aWFsbHkgYXNzaWduZWQgVkdBX1NXSVRDSEVST09fVU5LTk9XTl9JRAo+PiAtICogCWFuZCBs YXRlciBnaXZlbiB0aGVpciB0cnVlIGlkIGluIHZnYV9zd2l0Y2hlcm9vX2VuYWJsZSgpCj4+ICsg KglzbyBncHVzIGFyZSBpbml0aWFsbHkgYXNzaWduZWQgVkdBX1NXSVRDSEVST09fVU5LTk9XTl9J RAo+PiArICoJYW5kIGxhdGVyIGdpdmVuIHRoZWlyIHRydWUgaWQgaW4gdmdhX3N3aXRjaGVyb29f ZW5hYmxlKCkKPj4gICAqIEBhY3RpdmU6IHdoZXRoZXIgdGhlIG91dHB1dHMgYXJlIGN1cnJlbnRs eSBzd2l0Y2hlZCB0byB0aGlzIGNsaWVudAo+PiAgICogQGRyaXZlcl9wb3dlcl9jb250cm9sOiB3 aGV0aGVyIHBvd2VyIHN0YXRlIGlzIGNvbnRyb2xsZWQgYnkgdGhlIGRyaXZlcidzCj4+IC0gKiAJ cnVudGltZSBwbS4gSWYgdHJ1ZSwgd3JpdGluZyBPTiBhbmQgT0ZGIHRvIHRoZSB2Z2Ffc3dpdGNo ZXJvbyBkZWJ1Z2ZzCj4+IC0gKiAJaW50ZXJmYWNlIGlzIGEgbm8tb3Agc28gYXMgbm90IHRvIGlu dGVyZmVyZSB3aXRoIHJ1bnRpbWUgcG0KPj4gKyAqCXJ1bnRpbWUgcG0uIElmIHRydWUsIHdyaXRp bmcgT04gYW5kIE9GRiB0byB0aGUgdmdhX3N3aXRjaGVyb28gZGVidWdmcwo+PiArICoJaW50ZXJm YWNlIGlzIGEgbm8tb3Agc28gYXMgbm90IHRvIGludGVyZmVyZSB3aXRoIHJ1bnRpbWUgcG0KPj4g ICAqIEBsaXN0OiBjbGllbnQgbGlzdAo+PiAgICoKPj4gICAqIFJlZ2lzdGVyZWQgY2xpZW50LiBB IGNsaWVudCBjYW4gYmUgZWl0aGVyIGEgR1BVIG9yIGFuIGF1ZGlvIGRldmljZSBvbiBhIEdQVS4K Pj4gQEAgLTEyNiwxMyArMTI2LDEzIEBAIHN0YXRpYyBERUZJTkVfTVVURVgodmdhc3JfbXV0ZXgp Owo+PiAgLyoqCj4+ICAgKiBzdHJ1Y3Qgdmdhc3JfcHJpdiAtIHZnYV9zd2l0Y2hlcm9vIHByaXZh dGUgZGF0YQo+PiAgICogQGFjdGl2ZTogd2hldGhlciB2Z2Ffc3dpdGNoZXJvbyBpcyBlbmFibGVk Lgo+PiAtICogCVByZXJlcXVpc2l0ZSBpcyB0aGUgcmVnaXN0cmF0aW9uIG9mIHR3byBHUFVzIGFu ZCBhIGhhbmRsZXIKPj4gKyAqCVByZXJlcXVpc2l0ZSBpcyB0aGUgcmVnaXN0cmF0aW9uIG9mIHR3 byBHUFVzIGFuZCBhIGhhbmRsZXIKPj4gICAqIEBkZWxheWVkX3N3aXRjaF9hY3RpdmU6IHdoZXRo ZXIgYSBkZWxheWVkIHN3aXRjaCBpcyBwZW5kaW5nCj4+ICAgKiBAZGVsYXllZF9jbGllbnRfaWQ6 IGNsaWVudCB0byB3aGljaCBhIGRlbGF5ZWQgc3dpdGNoIGlzIHBlbmRpbmcKPj4gICAqIEBkZWJ1 Z2ZzX3Jvb3Q6IGRpcmVjdG9yeSBmb3IgdmdhX3N3aXRjaGVyb28gZGVidWdmcyBpbnRlcmZhY2UK Pj4gICAqIEBzd2l0Y2hfZmlsZTogZmlsZSBmb3IgdmdhX3N3aXRjaGVyb28gZGVidWdmcyBpbnRl cmZhY2UKPj4gICAqIEByZWdpc3RlcmVkX2NsaWVudHM6IG51bWJlciBvZiByZWdpc3RlcmVkIEdQ VXMKPj4gLSAqIAkoY291bnRpbmcgb25seSB2Z2EgY2xpZW50cywgbm90IGF1ZGlvIGNsaWVudHMp Cj4+ICsgKgkoY291bnRpbmcgb25seSB2Z2EgY2xpZW50cywgbm90IGF1ZGlvIGNsaWVudHMpCj4+ ICAgKiBAY2xpZW50czogbGlzdCBvZiByZWdpc3RlcmVkIGNsaWVudHMKPj4gICAqIEBoYW5kbGVy OiByZWdpc3RlcmVkIGhhbmRsZXIKPj4gICAqIEBoYW5kbGVyX2ZsYWdzOiBmbGFncyBvZiByZWdp c3RlcmVkIGhhbmRsZXIKPj4gQEAgLTIxNCw4ICsyMTQsOSBAQCBzdGF0aWMgdm9pZCB2Z2Ffc3dp dGNoZXJvb19lbmFibGUodm9pZCkKPj4gICAqCj4+ICAgKiBSZXR1cm46IDAgb24gc3VjY2Vzcywg LUVJTlZBTCBpZiBhIGhhbmRsZXIgd2FzIGFscmVhZHkgcmVnaXN0ZXJlZC4KPj4gICAqLwo+PiAt aW50IHZnYV9zd2l0Y2hlcm9vX3JlZ2lzdGVyX2hhbmRsZXIoY29uc3Qgc3RydWN0IHZnYV9zd2l0 Y2hlcm9vX2hhbmRsZXIgKmhhbmRsZXIsCj4+IC0JCQkJICAgIGVudW0gdmdhX3N3aXRjaGVyb29f aGFuZGxlcl9mbGFnc190IGhhbmRsZXJfZmxhZ3MpCj4+ICtpbnQgdmdhX3N3aXRjaGVyb29fcmVn aXN0ZXJfaGFuZGxlcigKPj4gKwkJCSAgY29uc3Qgc3RydWN0IHZnYV9zd2l0Y2hlcm9vX2hhbmRs ZXIgKmhhbmRsZXIsCj4+ICsJCQkgIGVudW0gdmdhX3N3aXRjaGVyb29faGFuZGxlcl9mbGFnc190 IGhhbmRsZXJfZmxhZ3MpCj4+ICB7Cj4+ICAJbXV0ZXhfbG9jaygmdmdhc3JfbXV0ZXgpOwo+PiAg CWlmICh2Z2Fzcl9wcml2LmhhbmRsZXIpIHsKPj4gQEAgLTMwNSw3ICszMDYsNyBAQCBzdGF0aWMg aW50IHJlZ2lzdGVyX2NsaWVudChzdHJ1Y3QgcGNpX2RldiAqcGRldiwKPj4gICAqIEBwZGV2OiBj bGllbnQgcGNpIGRldmljZQo+PiAgICogQG9wczogY2xpZW50IGNhbGxiYWNrcwo+PiAgICogQGRy aXZlcl9wb3dlcl9jb250cm9sOiB3aGV0aGVyIHBvd2VyIHN0YXRlIGlzIGNvbnRyb2xsZWQgYnkg dGhlIGRyaXZlcidzCj4+IC0gKiAJcnVudGltZSBwbQo+PiArICoJcnVudGltZSBwbQo+PiAgICoK Pj4gICAqIFJlZ2lzdGVyIHZnYSBjbGllbnQgKEdQVSkuIEVuYWJsZSB2Z2Ffc3dpdGNoZXJvbyBp ZiBhbm90aGVyIEdQVSBhbmQgYQo+PiAgICogaGFuZGxlciBoYXZlIGFscmVhZHkgcmVnaXN0ZXJl ZC4gVGhlIHBvd2VyIHN0YXRlIG9mIHRoZSBjbGllbnQgaXMgYXNzdW1lZAo+PiBAQCAtMzM3LDgg KzMzOCw4IEBAIEVYUE9SVF9TWU1CT0wodmdhX3N3aXRjaGVyb29fcmVnaXN0ZXJfY2xpZW50KTsK Pj4gICAqIFJldHVybjogMCBvbiBzdWNjZXNzLCAtRU5PTUVNIG9uIG1lbW9yeSBhbGxvY2F0aW9u IGVycm9yLgo+PiAgICovCj4+ICBpbnQgdmdhX3N3aXRjaGVyb29fcmVnaXN0ZXJfYXVkaW9fY2xp ZW50KHN0cnVjdCBwY2lfZGV2ICpwZGV2LAo+PiAtCQkJCQkgY29uc3Qgc3RydWN0IHZnYV9zd2l0 Y2hlcm9vX2NsaWVudF9vcHMgKm9wcywKPj4gLQkJCQkJIGVudW0gdmdhX3N3aXRjaGVyb29fY2xp ZW50X2lkIGlkKQo+PiArCQkJY29uc3Qgc3RydWN0IHZnYV9zd2l0Y2hlcm9vX2NsaWVudF9vcHMg Km9wcywKPj4gKwkJCWVudW0gdmdhX3N3aXRjaGVyb29fY2xpZW50X2lkIGlkKQo+PiAgewo+PiAg CXJldHVybiByZWdpc3Rlcl9jbGllbnQocGRldiwgb3BzLCBpZCB8IElEX0JJVF9BVURJTywgZmFs c2UsIGZhbHNlKTsKPj4gIH0KPj4gQEAgLTEwODQsNyArMTA4NSw4IEBAIHN0YXRpYyBpbnQgdmdh X3N3aXRjaGVyb29fcnVudGltZV9yZXN1bWVfaGRtaV9hdWRpbyhzdHJ1Y3QgZGV2aWNlICpkZXYp Cj4+ICAJaW50IHJldDsKPj4gIAo+PiAgCS8qIHdlIG5lZWQgdG8gY2hlY2sgaWYgd2UgaGF2ZSB0 byBzd2l0Y2ggYmFjayBvbiB0aGUgdmlkZW8KPj4gLQkgICBkZXZpY2Ugc28gdGhlIGF1ZGlvIGRl dmljZSBjYW4gY29tZSBiYWNrICovCj4+ICsJICogZGV2aWNlIHNvIHRoZSBhdWRpbyBkZXZpY2Ug Y2FuIGNvbWUgYmFjawo+PiArCSAqLwo+PiAgCW11dGV4X2xvY2soJnZnYXNyX211dGV4KTsKPj4g IAlsaXN0X2Zvcl9lYWNoX2VudHJ5KGNsaWVudCwgJnZnYXNyX3ByaXYuY2xpZW50cywgbGlzdCkg ewo+PiAgCQlpZiAoUENJX1NMT1QoY2xpZW50LT5wZGV2LT5kZXZmbikgPT0gUENJX1NMT1QocGRl di0+ZGV2Zm4pICYmCj4+IEBAIC0xMTEyLDcgKzExMTQsNyBAQCBzdGF0aWMgaW50IHZnYV9zd2l0 Y2hlcm9vX3J1bnRpbWVfcmVzdW1lX2hkbWlfYXVkaW8oc3RydWN0IGRldmljZSAqZGV2KQo+PiAg Cj4+ICAvKioKPj4gICAqIHZnYV9zd2l0Y2hlcm9vX2luaXRfZG9tYWluX3BtX29wdGltdXNfaGRt aV9hdWRpbygpIC0gaGVscGVyIGZvciBkcml2ZXIKPj4gLSAqIAlwb3dlciBjb250cm9sCj4+ICsg Kglwb3dlciBjb250cm9sCj4+ICAgKiBAZGV2OiBhdWRpbyBjbGllbnQgZGV2aWNlCj4+ICAgKiBA ZG9tYWluOiBwb3dlciBkb21haW4KPj4gICAqCj4+IC0tIAo+PiAyLjcuNAo+PiAKPj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+PiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKSmFu aSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdCAJvh (ORCPT ); Wed, 1 Mar 2017 04:51:37 -0500 Received: from mga01.intel.com ([192.55.52.88]:1734 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbdCAJvd (ORCPT ); Wed, 1 Mar 2017 04:51:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,224,1484035200"; d="scan'208";a="829665926" From: Jani Nikula To: Daniel Vetter , Joan Jani Cc: "daniel.vetter\@intel.com" , "linux-kernel\@vger.kernel.org" , "dri-devel\@lists.freedesktop.org" Subject: Re: [PATCH 3/3] drivers:gpu: vga :vga_switcheroo.c : Fixed some coding style issues In-Reply-To: <20170301084544.rx5tluo74f3p2x66@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170301084544.rx5tluo74f3p2x66@phenom.ffwll.local> Date: Wed, 01 Mar 2017 11:50:56 +0200 Message-ID: <87wpc9colb.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Mar 2017, Daniel Vetter wrote: > On Tue, Feb 28, 2017 at 06:59:52PM +0000, Joan Jani wrote: >> Fixed the following style issues >> >> drivers/gpu/vga/vga_switcheroo.c:98: WARNING: please, no space before tabs >> drivers/gpu/vga/vga_switcheroo.c:99: WARNING: please, no space before tabs >> drivers/gpu/vga/vga_switcheroo.c:102: WARNING: please, no space before tabs >> drivers/gpu/vga/vga_switcheroo.c:103: WARNING: please, no space before tabs >> drivers/gpu/vga/vga_switcheroo.c:129: WARNING: please, no space before tabs >> drivers/gpu/vga/vga_switcheroo.c:135: WARNING: please, no space before tabs >> drivers/gpu/vga/vga_switcheroo.c:217: WARNING: line over 80 characters >> drivers/gpu/vga/vga_switcheroo.c:218: WARNING: line over 80 characters >> drivers/gpu/vga/vga_switcheroo.c:308: WARNING: please, no space before tabs >> drivers/gpu/vga/vga_switcheroo.c:340: WARNING: line over 80 characters >> drivers/gpu/vga/vga_switcheroo.c:1087: WARNING: Block comments use * on subsequent lines >> drivers/gpu/vga/vga_switcheroo.c:1087: WARNING: Block comments use a trailing */ on a separate line >> >> Signed-off-by: Joan Jani > > Applied to drm-misc for 4.12, thanks. Frankly, I wish you hadn't. The patch changed the perfectly fine: int vga_switcheroo_register_handler(const struct vga_switcheroo_handler *handler, enum vga_switcheroo_handler_flags_t handler_flags) into horrendous: int vga_switcheroo_register_handler( const struct vga_switcheroo_handler *handler, enum vga_switcheroo_handler_flags_t handler_flags) Just to appease the 80 column rule. Ditto for vga_switcheroo_register_audio_client. This is why we don't generally want pure checkpatch fixes on existing files. They don't make things better. BR, Jani. > -Daniel > >> --- >> drivers/gpu/vga/vga_switcheroo.c | 28 +++++++++++++++------------- >> 1 file changed, 15 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c >> index 5f962bf..3cd153c 100644 >> --- a/drivers/gpu/vga/vga_switcheroo.c >> +++ b/drivers/gpu/vga/vga_switcheroo.c >> @@ -95,12 +95,12 @@ >> * @pwr_state: current power state >> * @ops: client callbacks >> * @id: client identifier. Determining the id requires the handler, >> - * so gpus are initially assigned VGA_SWITCHEROO_UNKNOWN_ID >> - * and later given their true id in vga_switcheroo_enable() >> + * so gpus are initially assigned VGA_SWITCHEROO_UNKNOWN_ID >> + * and later given their true id in vga_switcheroo_enable() >> * @active: whether the outputs are currently switched to this client >> * @driver_power_control: whether power state is controlled by the driver's >> - * runtime pm. If true, writing ON and OFF to the vga_switcheroo debugfs >> - * interface is a no-op so as not to interfere with runtime pm >> + * runtime pm. If true, writing ON and OFF to the vga_switcheroo debugfs >> + * interface is a no-op so as not to interfere with runtime pm >> * @list: client list >> * >> * Registered client. A client can be either a GPU or an audio device on a GPU. >> @@ -126,13 +126,13 @@ static DEFINE_MUTEX(vgasr_mutex); >> /** >> * struct vgasr_priv - vga_switcheroo private data >> * @active: whether vga_switcheroo is enabled. >> - * Prerequisite is the registration of two GPUs and a handler >> + * Prerequisite is the registration of two GPUs and a handler >> * @delayed_switch_active: whether a delayed switch is pending >> * @delayed_client_id: client to which a delayed switch is pending >> * @debugfs_root: directory for vga_switcheroo debugfs interface >> * @switch_file: file for vga_switcheroo debugfs interface >> * @registered_clients: number of registered GPUs >> - * (counting only vga clients, not audio clients) >> + * (counting only vga clients, not audio clients) >> * @clients: list of registered clients >> * @handler: registered handler >> * @handler_flags: flags of registered handler >> @@ -214,8 +214,9 @@ static void vga_switcheroo_enable(void) >> * >> * Return: 0 on success, -EINVAL if a handler was already registered. >> */ >> -int vga_switcheroo_register_handler(const struct vga_switcheroo_handler *handler, >> - enum vga_switcheroo_handler_flags_t handler_flags) >> +int vga_switcheroo_register_handler( >> + const struct vga_switcheroo_handler *handler, >> + enum vga_switcheroo_handler_flags_t handler_flags) >> { >> mutex_lock(&vgasr_mutex); >> if (vgasr_priv.handler) { >> @@ -305,7 +306,7 @@ static int register_client(struct pci_dev *pdev, >> * @pdev: client pci device >> * @ops: client callbacks >> * @driver_power_control: whether power state is controlled by the driver's >> - * runtime pm >> + * runtime pm >> * >> * Register vga client (GPU). Enable vga_switcheroo if another GPU and a >> * handler have already registered. The power state of the client is assumed >> @@ -337,8 +338,8 @@ EXPORT_SYMBOL(vga_switcheroo_register_client); >> * Return: 0 on success, -ENOMEM on memory allocation error. >> */ >> int vga_switcheroo_register_audio_client(struct pci_dev *pdev, >> - const struct vga_switcheroo_client_ops *ops, >> - enum vga_switcheroo_client_id id) >> + const struct vga_switcheroo_client_ops *ops, >> + enum vga_switcheroo_client_id id) >> { >> return register_client(pdev, ops, id | ID_BIT_AUDIO, false, false); >> } >> @@ -1084,7 +1085,8 @@ static int vga_switcheroo_runtime_resume_hdmi_audio(struct device *dev) >> int ret; >> >> /* we need to check if we have to switch back on the video >> - device so the audio device can come back */ >> + * device so the audio device can come back >> + */ >> mutex_lock(&vgasr_mutex); >> list_for_each_entry(client, &vgasr_priv.clients, list) { >> if (PCI_SLOT(client->pdev->devfn) == PCI_SLOT(pdev->devfn) && >> @@ -1112,7 +1114,7 @@ static int vga_switcheroo_runtime_resume_hdmi_audio(struct device *dev) >> >> /** >> * vga_switcheroo_init_domain_pm_optimus_hdmi_audio() - helper for driver >> - * power control >> + * power control >> * @dev: audio client device >> * @domain: power domain >> * >> -- >> 2.7.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center