All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, marc.zyngier@arm.com,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH 6/6] run_tests: allow passing of options to QEMU
Date: Tue, 17 Jan 2017 12:07:49 +0000	[thread overview]
Message-ID: <87wpdtubxm.fsf@linaro.org> (raw)
In-Reply-To: <648638bd-a90e-ee98-337a-223ed533f53a@redhat.com>


Paolo Bonzini <pbonzini@redhat.com> writes:

> On 12/01/2017 18:32, Andrew Jones wrote:
>>>
>>> +# Any options left for QEMU?
>>> +shift $((OPTIND-1))
>>> +if [ "$#" -gt  0 ]; then
>>> +    extra_opts="$@"
>>> +fi
>> We can unconditionally do the extra_opts="$@", extra_opts will just
>> be null in the case there aren't more args, like it was before.
>
> extra_opts is not an array, so this would mess up options that contain
> spaces.  (Alex's patch in general, not your tweak).

Is it worth treating extra_opts as an array?

>
> Paolo
>
>>> +
>>>  RUNTIME_log_stderr () { cat >> test.log; }
>>>  RUNTIME_log_stdout () {
>>>      if [ "$PRETTY_PRINT_STACKS" = "yes" ]; then
>>> @@ -59,4 +68,4 @@ RUNTIME_log_stdout () {
>>>  config=$TEST_DIR/unittests.cfg
>>>  rm -f test.log
>>>  printf "BUILD_HEAD=$(cat build-head)\n\n" > test.log
>>> -for_each_unittest $config run
>>> +for_each_unittest $config run "$extra_opts"


--
Alex Bennée
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: alex.bennee@linaro.org (Alex Bennée)
To: linux-arm-kernel@lists.infradead.org
Subject: [kvm-unit-tests PATCH 6/6] run_tests: allow passing of options to QEMU
Date: Tue, 17 Jan 2017 12:07:49 +0000	[thread overview]
Message-ID: <87wpdtubxm.fsf@linaro.org> (raw)
In-Reply-To: <648638bd-a90e-ee98-337a-223ed533f53a@redhat.com>


Paolo Bonzini <pbonzini@redhat.com> writes:

> On 12/01/2017 18:32, Andrew Jones wrote:
>>>
>>> +# Any options left for QEMU?
>>> +shift $((OPTIND-1))
>>> +if [ "$#" -gt  0 ]; then
>>> +    extra_opts="$@"
>>> +fi
>> We can unconditionally do the extra_opts="$@", extra_opts will just
>> be null in the case there aren't more args, like it was before.
>
> extra_opts is not an array, so this would mess up options that contain
> spaces.  (Alex's patch in general, not your tweak).

Is it worth treating extra_opts as an array?

>
> Paolo
>
>>> +
>>>  RUNTIME_log_stderr () { cat >> test.log; }
>>>  RUNTIME_log_stdout () {
>>>      if [ "$PRETTY_PRINT_STACKS" = "yes" ]; then
>>> @@ -59,4 +68,4 @@ RUNTIME_log_stdout () {
>>>  config=$TEST_DIR/unittests.cfg
>>>  rm -f test.log
>>>  printf "BUILD_HEAD=$(cat build-head)\n\n" > test.log
>>> -for_each_unittest $config run
>>> +for_each_unittest $config run "$extra_opts"


--
Alex Benn?e

  reply	other threads:[~2017-01-17 12:06 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 16:28 [kvm-unit-tests PATCH 0/6] Documentation misc fixes Alex Bennée
2017-01-11 16:28 ` Alex Bennée
2017-01-11 16:28 ` [kvm-unit-tests PATCH 1/6] libcflat: add PRI(dux)32 format types Alex Bennée
2017-01-11 16:28   ` Alex Bennée
2017-01-12 12:29   ` Paolo Bonzini
2017-01-12 12:29     ` Paolo Bonzini
2017-01-12 12:39     ` Alex Bennée
2017-01-12 12:39       ` Alex Bennée
2017-01-12 16:56     ` Andrew Jones
2017-01-12 16:56       ` Andrew Jones
2017-01-12 17:18       ` Alex Bennée
2017-01-12 17:18         ` Alex Bennée
2017-01-12 17:43         ` Andrew Jones
2017-01-12 17:43           ` Andrew Jones
2017-01-12 17:44         ` Paolo Bonzini
2017-01-12 17:44           ` Paolo Bonzini
2017-01-12 18:01           ` Alex Bennée
2017-01-12 18:01             ` Alex Bennée
2017-01-13 18:03       ` Andrew Jones
2017-01-13 18:03         ` Andrew Jones
2017-01-11 16:28 ` [kvm-unit-tests PATCH 2/6] lib/pci: fix BAR format strings Alex Bennée
2017-01-11 16:28   ` Alex Bennée
2017-01-12 12:35   ` Paolo Bonzini
2017-01-12 12:35     ` Paolo Bonzini
2017-01-11 16:28 ` [kvm-unit-tests PATCH 3/6] docs: move README to README.md and symlink Alex Bennée
2017-01-11 16:28   ` Alex Bennée
2017-01-12 17:04   ` Andrew Jones
2017-01-12 17:04     ` Andrew Jones
2017-01-11 16:28 ` [kvm-unit-tests PATCH 4/6] docs: mention checkpatch in the README Alex Bennée
2017-01-11 16:28   ` Alex Bennée
2017-01-12 12:29   ` Paolo Bonzini
2017-01-12 12:29     ` Paolo Bonzini
2017-01-12 12:35     ` Alex Bennée
2017-01-12 12:35       ` Alex Bennée
2017-01-12 17:09       ` Andrew Jones
2017-01-12 17:09         ` Andrew Jones
2017-01-12 17:08     ` Andrew Jones
2017-01-12 17:08       ` Andrew Jones
2017-01-11 16:28 ` [kvm-unit-tests PATCH 5/6] docs: mention modifying env vars in README Alex Bennée
2017-01-11 16:28   ` Alex Bennée
2017-01-12 17:14   ` Andrew Jones
2017-01-12 17:14     ` Andrew Jones
2017-01-11 16:28 ` [kvm-unit-tests PATCH 6/6] run_tests: allow passing of options to QEMU Alex Bennée
2017-01-11 16:28   ` Alex Bennée
2017-01-12 12:30   ` Paolo Bonzini
2017-01-12 12:30     ` Paolo Bonzini
2017-01-12 17:32   ` Andrew Jones
2017-01-12 17:32     ` Andrew Jones
2017-01-12 17:50     ` Paolo Bonzini
2017-01-12 17:50       ` Paolo Bonzini
2017-01-17 12:07       ` Alex Bennée [this message]
2017-01-17 12:07         ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpdtubxm.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.