All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "michal.kazior@tieto.com" <michal.kazior@tieto.com>
Cc: Erik Stromdahl <erik.stromdahl@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC v2 05/11] ath10k: htc: refactorization
Date: Wed, 14 Dec 2016 13:49:10 +0000	[thread overview]
Message-ID: <87wpf2wrhm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQmRV59imnmSykjs=ym0qut9akUHzFKfAMioK=MT8my98A@mail.gmail.com>	(Michal Kazior's message of "Tue, 13 Dec 2016 20:21:53 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

>> I have made a few updates since I submitted the original RFC and created
>> a repo on github:
>>
>> https://github.com/erstrom/linux-ath
>>
>> I have a bunch of branches that are all based on the tags on the ath master.
>>
>> As of this moment the latest version is:
>>
>> ath-201612131156-ath10k-sdio
>>
>> This branch contains the original RFC patches plus some addons/fixes.
>>
>> In the above mentioned branch there are a few commits related to this
>> race condition. Perhaps you can have a look at them?
>>
>> The commits are:
>> 821672913328cf737c9616786dc28d2e4e8a4a90
>
> I would avoid if(bus==xx) checks.

Very much agreed. For example to enable HTT high latency support you
could add an enum to ath10k_core_create() with values for both high and
low latency. This way sdio.c and pci.c can enable the correct mode
during initialisation.

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "michal.kazior@tieto.com" <michal.kazior@tieto.com>
Cc: Erik Stromdahl <erik.stromdahl@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC v2 05/11] ath10k: htc: refactorization
Date: Wed, 14 Dec 2016 13:49:10 +0000	[thread overview]
Message-ID: <87wpf2wrhm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQmRV59imnmSykjs=ym0qut9akUHzFKfAMioK=MT8my98A@mail.gmail.com>       (Michal Kazior's message of "Tue, 13 Dec 2016 20:21:53 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

>> I have made a few updates since I submitted the original RFC and created
>> a repo on github:
>>
>> https://github.com/erstrom/linux-ath
>>
>> I have a bunch of branches that are all based on the tags on the ath mas=
ter.
>>
>> As of this moment the latest version is:
>>
>> ath-201612131156-ath10k-sdio
>>
>> This branch contains the original RFC patches plus some addons/fixes.
>>
>> In the above mentioned branch there are a few commits related to this
>> race condition. Perhaps you can have a look at them?
>>
>> The commits are:
>> 821672913328cf737c9616786dc28d2e4e8a4a90
>
> I would avoid if(bus=3D=3Dxx) checks.

Very much agreed. For example to enable HTT high latency support you
could add an enum to ath10k_core_create() with values for both high and
low latency. This way sdio.c and pci.c can enable the correct mode
during initialisation.

--=20
Kalle Valo=

  reply	other threads:[~2016-12-14 13:49 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 19:22 [RFC v2 00/11] ath10k sdio support Erik Stromdahl
2016-11-18 19:22 ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 01/11] ath10k: htc: made static function public Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 02/11] ath10k: htc: rx trailer lookahead support Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 03/11] ath10k: htc: Removal of unused struct members Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 04/11] ath10k: htc: Changed order of wait target and ep connect Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 05/11] ath10k: htc: refactorization Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-12-13 13:44   ` Valo, Kalle
2016-12-13 13:44     ` Valo, Kalle
2016-12-13 13:52     ` Michal Kazior
2016-12-13 13:52       ` Michal Kazior
2016-12-13 17:26       ` Valo, Kalle
2016-12-13 17:26         ` Valo, Kalle
2016-12-13 18:37         ` Erik Stromdahl
2016-12-13 18:37           ` Erik Stromdahl
2016-12-13 19:21           ` Michal Kazior
2016-12-13 19:21             ` Michal Kazior
2016-12-14 13:49             ` Valo, Kalle [this message]
2016-12-14 13:49               ` Valo, Kalle
2016-12-14 13:46           ` Valo, Kalle
2016-12-14 13:46             ` Valo, Kalle
2016-12-14 21:07             ` Erik Stromdahl
2016-12-14 21:07               ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 06/11] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-12-16 10:23   ` Valo, Kalle
2016-12-16 10:23     ` Valo, Kalle
2016-11-18 19:22 ` [RFC v2 07/11] ath10k: Added SDIO dbg masks Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 08/11] ath10k: Added ATH10K_BUS_SDIO enum Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 09/11] ath10k: Mailbox address definitions Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 10/11] ath10k: Added more host_interest members Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 11/11] ath10k: Added sdio support Erik Stromdahl
2016-11-18 19:22   ` Erik Stromdahl
2016-12-13 13:10   ` Valo, Kalle
2016-12-13 13:10     ` Valo, Kalle
2016-12-15 16:40   ` Valo, Kalle
2016-12-15 16:40     ` Valo, Kalle
2016-12-15 20:52     ` Erik Stromdahl
2016-12-15 20:52       ` Erik Stromdahl
2016-12-16 11:21   ` Valo, Kalle
2016-12-16 11:21     ` Valo, Kalle
2016-12-20 18:14     ` Erik Stromdahl
2016-12-20 18:14       ` Erik Stromdahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpf2wrhm.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=erik.stromdahl@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.