From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDtAW-00014G-Ip for qemu-devel@nongnu.org; Mon, 05 Dec 2016 08:18:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDtAT-0007su-EC for qemu-devel@nongnu.org; Mon, 05 Dec 2016 08:18:56 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:34251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cDtAT-0007sc-77 for qemu-devel@nongnu.org; Mon, 05 Dec 2016 08:18:53 -0500 Received: by mail-wm0-x22c.google.com with SMTP id u144so20445716wmu.1 for ; Mon, 05 Dec 2016 05:18:53 -0800 (PST) References: <1479906121-12211-1-git-send-email-rth@twiddle.net> <1479906121-12211-3-git-send-email-rth@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1479906121-12211-3-git-send-email-rth@twiddle.net> Date: Mon, 05 Dec 2016 13:18:50 +0000 Message-ID: <87wpfezf7p.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 02/64] tcg: Minor adjustments to deposit expanders List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org Richard Henderson writes: > Assert that len is not 0. > > Since we have asserted that ofs + len <= N, a later > check for len == N implies that ofs == 0. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > index c185b9c..b17f03f 100644 > --- a/tcg/tcg-op.c > +++ b/tcg/tcg-op.c > @@ -533,10 +533,11 @@ void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2, > TCGv_i32 t1; > > tcg_debug_assert(ofs < 32); > + tcg_debug_assert(len > 0); > tcg_debug_assert(len <= 32); > tcg_debug_assert(ofs + len <= 32); > > - if (ofs == 0 && len == 32) { > + if (len == 32) { > tcg_gen_mov_i32(ret, arg2); > return; > } > @@ -1718,10 +1719,11 @@ void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2, > TCGv_i64 t1; > > tcg_debug_assert(ofs < 64); > + tcg_debug_assert(len > 0); > tcg_debug_assert(len <= 64); > tcg_debug_assert(ofs + len <= 64); > > - if (ofs == 0 && len == 64) { > + if (len == 64) { > tcg_gen_mov_i64(ret, arg2); > return; > } Reviewed-by: Alex Bennée -- Alex Bennée