From: Kalle Valo <kvalo@codeaurora.org>
To: Prameela Rani Garnepudi <prameela.garnepudi@redpinesignals.com>
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
linux-wireless@vger.kernel.org, johannes.berg@intel.com,
hofrat@osadl.org, xypron.glpk@gmx.de
Subject: Re: [1/2] rsi: New firware loading method for RSI 91X devices
Date: Thu, 24 Nov 2016 13:50:53 +0200 [thread overview]
Message-ID: <87wpftf65d.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <188f9293-f6a8-bd2b-8c2a-79b620fa0787@redpinesignals.com> (Prameela Rani Garnepudi's message of "Thu, 24 Nov 2016 11:12:52 +0530")
Prameela Rani Garnepudi <prameela.garnepudi@redpinesignals.com> writes:
>
> On 11/09/2016 06:45 AM, Kalle Valo wrote:
>> Prameela Rani Garnepudi <prameela.j04cs@gmail.com> wrote:
>>> RSI deprecated the old firmware loading method and introduced
>>> new method using soft boot loader for 9113 chipsets.
>>> Current driver only supports 9113 device model hence firmware
>>> loading method has been changed.
>>>
>>> In the new method, complete RAM image and flash image are present
>>> in the flash. Two firmwares present in the device, Boot loader firmware
>>> and functional firmware. Boot loader firmware is fixed but functional
>>> firmware can be changed. Before loading the functional firmware, host
>>> issues commands to check whether existing firmware in the chip and the
>>> firmware file content to load are same or not. If not, host issues
>>> commands to load the RAM image and then boot loaded switches to the
>>> functioanl firmware.
>>>
>>> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
>> These two patches are quite big, difficult to review. Smaller changes
>> would help with that. Will review later.
>>
>> 2 patches set to Deferred.
>>
>> 9388629 [1/2] rsi: New firware loading method for RSI 91X devices
>> 9388627 [2/2] rsi: Device initialization sequence is changed
>>
> Hi,
>
> Can you please let me know when will you consider to review these two
> patches. Because these are the mandatory and important patches to go
> into the mail line kernel. If it gets too late can I send each one as
> patch set? Please let me know urgently.
I'm still catching up with everything after my travels, sorry for the
delay. I'm hoping to get to your patches in next few days and give
better answers.
>From the last review I noticed that you both moved functions and made
functionality changes in the same patch. These are two logically
different changes and should be in different patches to make the review
easier. That's why I put them to deferred in the first place.
--
Kalle Valo
next prev parent reply other threads:[~2016-11-24 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 10:09 [PATCH 1/2] rsi: New firware loading method for RSI 91X devices Prameela Rani Garnepudi
2016-11-09 1:15 ` [1/2] " Kalle Valo
[not found] ` <20161109011553.37D03612F2@smtp.codeaurora.org>
[not found] ` <188f9293-f6a8-bd2b-8c2a-79b620fa0787@redpinesignals.com>
2016-11-24 11:50 ` Kalle Valo [this message]
2016-11-28 18:57 ` [PATCH 1/2] " Kalle Valo
2016-11-28 19:02 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpftf65d.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=hofrat@osadl.org \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.garnepudi@redpinesignals.com \
--cc=prameela.j04cs@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.