From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>, mathias.nyman@intel.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
rogerq@ti.com
Subject: Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits
Date: Mon, 21 Nov 2016 13:56:00 +0200 [thread overview]
Message-ID: <87wpfxqc6n.fsf@linux.intel.com> (raw)
In-Reply-To: <bafc49b6-ca94-5560-2056-bcb8c15108de@ti.com>
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
Hi,
Roger Quadros <rogerq@ti.com> writes:
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index f945380..6553903 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1656,6 +1656,9 @@ struct xhci_hcd {
> #define XHCI_SSIC_PORT_UNUSED (1 << 22)
> #define XHCI_NO_64BIT_SUPPORT (1 << 23)
> #define XHCI_MISSING_CAS (1 << 24)
> +/* For controller with a broken Port Disable implementation */
> +#define XHCI_BROKEN_PORT_PED (1 << 21)
since back when I first wrote this, bit 21 has been taken. You should be
using bit 25 here.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2016-11-21 11:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 15:01 [PATCH 0/3] usb: xhci: Add broken port disable quirk Roger Quadros
2016-11-17 15:01 ` [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits Roger Quadros
2016-11-18 10:49 ` Sergei Shtylyov
2016-11-21 11:51 ` Roger Quadros
2016-11-21 11:51 ` [PATCH v2 " Roger Quadros
2016-11-21 11:56 ` Felipe Balbi [this message]
2016-11-21 13:05 ` Roger Quadros
2016-11-21 13:09 ` [PATCH v3 " Roger Quadros
2016-11-17 15:01 ` [PATCH 2/3] usb: host: xhci-plat: enable BROKEN_PED quirk if platform requested Roger Quadros
2016-11-17 15:01 ` [PATCH 3/3] usb: dwc3: host: pass quirk-broken-port-ped property for known broken revisions Roger Quadros
2017-01-03 12:37 ` [PATCH 0/3] usb: xhci: Add broken port disable quirk Roger Quadros
2017-01-03 12:53 ` Felipe Balbi
2017-01-03 16:32 ` Mathias Nyman
2017-01-24 14:59 ` Roger Quadros
2017-01-26 9:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpfxqc6n.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=rogerq@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.