diff for duplicates of <87wpgbekwg.fsf@free-electrons.com> diff --git a/a/1.txt b/N1/1.txt index 7f00f87..fc39d94 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,13 @@ Hi Thomas, - On jeu., nov. 10 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: + On jeu., nov. 10 2016, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > Hello, > > On Thu, 10 Nov 2016 01:09:50 +0100, Gregory CLEMENT wrote: > >> - bootrom { ->> + bootrom at 0 { +>> + bootrom@0 { >> compatible = "marvell,bootrom"; >> reg = <MBUS_ID(0x01, 0x1d) 0 0x100000>; > @@ -19,18 +19,18 @@ I chose to use the adress register inside the window memory. > > A good example of why I'm worried is the sa-sram case: > -> + crypto_sram0: sa-sram0 at 0 { +> + crypto_sram0: sa-sram0@0 { > compatible = "mmio-sram"; > reg = <MBUS_ID(0x09, 0x09) 0 0x800>; > -> + crypto_sram1: sa-sram1 at 0 { +> + crypto_sram1: sa-sram1@0 { > compatible = "mmio-sram"; > reg = <MBUS_ID(0x09, 0x05) 0 0x800>; > > The node names should be just "sram" without a number. Indeed for UARTs -> for example, you use uart at XYZ, uart at ABC and not uart0 at XYZ and -> uart1 at ABC. But then, if you do that, with your scheme, you end up with -> both nodes named sa-sram at 0. +> for example, you use uart@XYZ, uart@ABC and not uart0@XYZ and +> uart1@ABC. But then, if you do that, with your scheme, you end up with +> both nodes named sa-sram@0. > > Which clearly shows that the way you set this unit-address is not > correct: those two devices are mapped at completely different @@ -43,12 +43,12 @@ I don't know if there is an existing rules for this case. But I see your concern. What I propose then is to expose the memory windows ID by adding the target and the attributes like this: - crypto_sram0: sa-sram at 09_09_0 { + crypto_sram0: sa-sram@09_09_0 { compatible = "mmio-sram"; reg = <MBUS_ID(0x09, 0x09) 0 0x800>; - crypto_sram1: sa-sram at 09_05_0 { + crypto_sram1: sa-sram@09_05_0 { compatible = "mmio-sram"; reg = <MBUS_ID(0x09, 0x05) 0 0x800>; @@ -68,3 +68,7 @@ Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 0a51174..00b80ad 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,22 +1,29 @@ "ref\020161110001000.10619-1-gregory.clement@free-electrons.com\0" "ref\020161110001000.10619-5-gregory.clement@free-electrons.com\0" "ref\020161110092221.0219490b@free-electrons.com\0" - "From\0gregory.clement@free-electrons.com (Gregory CLEMENT)\0" - "Subject\0[PATCH 04/14] ARM: dts: armada-375: Fixup bootrom DT warning\0" + "ref\020161110092221.0219490b-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org\0" + "From\0Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\0" + "Subject\0Re: [PATCH 04/14] ARM: dts: armada-375: Fixup bootrom DT warning\0" "Date\0Thu, 10 Nov 2016 10:36:47 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\0" + "Cc\0Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>" + Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> + Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + " devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" "\00:1\0" "b\0" "Hi Thomas,\n" " \n" - " On jeu., nov. 10 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:\n" + " On jeu., nov. 10 2016, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:\n" "\n" "> Hello,\n" ">\n" "> On Thu, 10 Nov 2016 01:09:50 +0100, Gregory CLEMENT wrote:\n" ">\n" ">> -\t\tbootrom {\n" - ">> +\t\tbootrom at 0 {\n" + ">> +\t\tbootrom@0 {\n" ">> \t\t\tcompatible = \"marvell,bootrom\";\n" ">> \t\t\treg = <MBUS_ID(0x01, 0x1d) 0 0x100000>;\n" ">\n" @@ -28,18 +35,18 @@ ">\n" "> A good example of why I'm worried is the sa-sram case:\n" ">\n" - "> +\t\tcrypto_sram0: sa-sram0 at 0 {\n" + "> +\t\tcrypto_sram0: sa-sram0@0 {\n" "> \t\t\tcompatible = \"mmio-sram\";\n" "> \t\t\treg = <MBUS_ID(0x09, 0x09) 0 0x800>;\n" ">\n" - "> +\t\tcrypto_sram1: sa-sram1 at 0 {\n" + "> +\t\tcrypto_sram1: sa-sram1@0 {\n" "> \t\t\tcompatible = \"mmio-sram\";\n" "> \t\t\treg = <MBUS_ID(0x09, 0x05) 0 0x800>;\n" ">\n" "> The node names should be just \"sram\" without a number. Indeed for UARTs\n" - "> for example, you use uart at XYZ, uart at ABC and not uart0 at XYZ and\n" - "> uart1 at ABC. But then, if you do that, with your scheme, you end up with\n" - "> both nodes named sa-sram at 0.\n" + "> for example, you use uart@XYZ, uart@ABC and not uart0@XYZ and\n" + "> uart1@ABC. But then, if you do that, with your scheme, you end up with\n" + "> both nodes named sa-sram@0.\n" ">\n" "> Which clearly shows that the way you set this unit-address is not\n" "> correct: those two devices are mapped at completely different\n" @@ -52,12 +59,12 @@ "concern. What I propose then is to expose the memory windows ID by\n" "adding the target and the attributes like this:\n" "\n" - "\t\tcrypto_sram0: sa-sram at 09_09_0 {\n" + "\t\tcrypto_sram0: sa-sram@09_09_0 {\n" " \t\t\tcompatible = \"mmio-sram\";\n" " \t\t\treg = <MBUS_ID(0x09, 0x09) 0 0x800>;\n" "\n" "\n" - "\t\tcrypto_sram1: sa-sram at 09_05_0 {\n" + "\t\tcrypto_sram1: sa-sram@09_05_0 {\n" " \t\t\tcompatible = \"mmio-sram\";\n" " \t\t\treg = <MBUS_ID(0x09, 0x05) 0 0x800>;\n" "\n" @@ -76,6 +83,10 @@ "Gregory Clement, Free Electrons\n" "Kernel, drivers, real-time and embedded Linux\n" "development, consulting, training and support.\n" - http://free-electrons.com + "http://free-electrons.com\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -3dcb1e09fe021165e19f94a081136857dd0eea1b9dd712de93bf1319b18f9a5b +193091e2c2c73f7ce394e246413ed99862ced0460ebb4ecf2638c6eea057817a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.