From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52683)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1c1uuR-0003xl-CS
	for qemu-devel@nongnu.org; Wed, 02 Nov 2016 08:44:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1c1uuN-0001oQ-Ii
	for qemu-devel@nongnu.org; Wed, 02 Nov 2016 08:44:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16075)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1c1uuN-0001ns-DC
	for qemu-devel@nongnu.org; Wed, 02 Nov 2016 08:44:47 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1476859665-30133-1-git-send-email-caoj.fnst@cn.fujitsu.com>
Date: Wed, 02 Nov 2016 13:44:43 +0100
In-Reply-To: <1476859665-30133-1-git-send-email-caoj.fnst@cn.fujitsu.com> (Cao
	jin's message of "Wed, 19 Oct 2016 14:47:35 +0800")
Message-ID: <87wpgmnj9g.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, Jiri Pirko <jiri@resnulli.us>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, Hannes Reinecke <hare@suse.de>, Dmitry Fleytman <dmitry@daynix.com>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

Cao jin <caoj.fnst@cn.fujitsu.com> writes:

> v4 changelog
> 1. add the missed comment of "errp" in the msix_init's function comment
> 2. fix typo: msic --> msix
> 3. fix a build failure due to "copy&paste" error, in patch
>    "megasas: change behaviour of msix switch"
> 4. separate the issus-fix part of vmxnet3's patch
> 5. a new patch added in the end
> 6. rebase on Eric Auger's "Convert VFIO-PCI to realize" series
>
> CC: Jiri Pirko <jiri@resnulli.us>
> CC: Gerd Hoffmann <kraxel@redhat.com>
> CC: Dmitry Fleytman <dmitry@daynix.com>
> CC: Jason Wang <jasowang@redhat.com>
> CC: Michael S. Tsirkin <mst@redhat.com>
> CC: Hannes Reinecke <hare@suse.de>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Alex Williamson <alex.williamson@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Marcel Apfelbaum <marcel@redhat.com>

I had two small comments that could perhaps be address on commit.
Preferrably with them addressed, series
Reviewed-by: Markus Armbruster <armbru@redhat.com>