From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Move hangcheck code out from i915_irq.c
Date: Tue, 01 Nov 2016 18:39:54 +0200 [thread overview]
Message-ID: <87wpgnnoh1.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20161101162258.GH26576@nuc-i3427.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> On Tue, Nov 01, 2016 at 06:03:21PM +0200, Mika Kuoppala wrote:
>> Create new file for hangcheck specific code, intel_engine_hangcheck.c,
>> and move all the related code in it.
>>
>> No functional changes.
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>> ---
>> drivers/gpu/drm/i915/Makefile | 1 +
>> drivers/gpu/drm/i915/i915_drv.c | 1 +
>> drivers/gpu/drm/i915/i915_drv.h | 1 +
>> drivers/gpu/drm/i915/i915_irq.c | 417 ------------------------
>> drivers/gpu/drm/i915/intel_engine_cs.c | 5 -
>> drivers/gpu/drm/i915/intel_engine_hangcheck.c | 450 ++++++++++++++++++++++++++
>> 6 files changed, 453 insertions(+), 422 deletions(-)
>> create mode 100644 drivers/gpu/drm/i915/intel_engine_hangcheck.c
>>
>> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>> index 240ce9a..e772664 100644
>> --- a/drivers/gpu/drm/i915/Makefile
>> +++ b/drivers/gpu/drm/i915/Makefile
>> @@ -47,6 +47,7 @@ i915-y += i915_cmd_parser.o \
>> i915_trace_points.o \
>> intel_breadcrumbs.o \
>> intel_engine_cs.o \
>> + intel_engine_hangcheck.o \
>
> Hmm. intel_engine_hangcheck. Please do include a signpost as to why this
> makes more sense than intel_hangcheck.c
intel_hangcheck.c makes more sense. New version soon.
-Mika
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-01 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 16:03 [PATCH 1/2] drm/i915: Move hangcheck code out from i915_irq.c Mika Kuoppala
2016-11-01 16:03 ` [PATCH 2/2] drm/i915: Move error state capture " Mika Kuoppala
2016-11-01 16:16 ` Chris Wilson
2016-11-01 16:22 ` [PATCH 1/2] drm/i915: Move hangcheck " Chris Wilson
2016-11-01 16:39 ` Mika Kuoppala [this message]
2016-11-01 17:46 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpgnnoh1.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.