From: Jani Nikula <jani.nikula@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/crtc: constify drm_crtc_mask parameter
Date: Thu, 13 Oct 2016 15:17:34 +0300 [thread overview]
Message-ID: <87wphcwiht.fsf@intel.com> (raw)
In-Reply-To: <6e32d013-6fee-34ad-f8d2-59139f3dc4c1@linux.intel.com>
On Thu, 13 Oct 2016, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
> Now that drm_crtc_index takes a const, the same can be done for drm_crtc_mask.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 0aa292526567..98ec40713921 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -1354,7 +1354,7 @@ static inline unsigned int drm_crtc_index(const struct drm_crtc *crtc)
> * Given a registered CRTC, return the mask bit of that CRTC for an
> * encoder's possible_crtcs field.
> */
> -static inline uint32_t drm_crtc_mask(struct drm_crtc *crtc)
> +static inline uint32_t drm_crtc_mask(const struct drm_crtc *crtc)
> {
> return 1 << drm_crtc_index(crtc);
> }
> diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h
> index 387e33a4d6ee..c7438ff0d609 100644
> --- a/include/drm/drm_encoder.h
> +++ b/include/drm/drm_encoder.h
> @@ -189,7 +189,7 @@ static inline unsigned int drm_encoder_index(struct drm_encoder *encoder)
> }
>
> /* FIXME: We have an include file mess still, drm_crtc.h needs untangling. */
> -static inline uint32_t drm_crtc_mask(struct drm_crtc *crtc);
> +static inline uint32_t drm_crtc_mask(const struct drm_crtc *crtc);
>
> /**
> * drm_encoder_crtc_ok - can a given crtc drive a given encoder?
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-10-13 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 8:38 [PATCH] drm/crtc: constify drm_crtc_mask parameter Maarten Lankhorst
2016-10-13 12:17 ` Jani Nikula [this message]
2016-10-17 6:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wphcwiht.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.