All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Checkpatch false positives
Date: Tue, 06 Sep 2016 12:19:01 +0200	[thread overview]
Message-ID: <87wpip8h62.fsf@fimbulvetr.bsc.es> (raw)
In-Reply-To: <0968a336-f276-633c-4d48-2e4fc81846be@redhat.com> (Paolo Bonzini's message of "Tue, 6 Sep 2016 11:16:06 +0200")

Paolo Bonzini writes:

> On 06/09/2016 11:11, Lluís Vilanova wrote:
>> no-reply  writes:
>>> Checking PATCH 1/6: hypertrace: Add documentation...
>>> ERROR: trailing whitespace
>>> #109: FILE: docs/hypertrace.txt:92:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #110: FILE: docs/hypertrace.txt:93:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #117: FILE: docs/hypertrace.txt:100:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #123: FILE: docs/hypertrace.txt:106:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #130: FILE: docs/hypertrace.txt:113:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #154: FILE: docs/hypertrace.txt:137:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #156: FILE: docs/hypertrace.txt:139:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #160: FILE: docs/hypertrace.txt:143:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #171: FILE: docs/hypertrace.txt:154:
>>> +    $
>> 
>>> ERROR: trailing whitespace
>>> #181: FILE: docs/hypertrace.txt:164:
>>> +    $
>> 
>>> total: 10 errors, 0 warnings, 236 lines checked
>> 
>>> Your patch has style problems, please review.  If any of these errors
>>> are false positives report them to the maintainer, see
>>> CHECKPATCH in MAINTAINERS.
>> 
>> The errors above are false positives. AFAIR, in .txt files empty lines in code
>> examples need 4 white spaces to let the wiki properly render them as a single
>> code example block.

> Right, can you make a patch for that?  It should recognize exactly 4
> patches and only apply to .txt and .md files.

Ok. I won't properly check this only applies to lines where surrounding text is
4-column-indented, though, so it can have false negatives.

Cheers,
  Lluis

      reply	other threads:[~2016-09-06 10:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 18:56 [Qemu-devel] [PATCH v2 0/6] hypertrace: Lightweight guest-to-QEMU trace channel Lluís Vilanova
2016-09-05 18:56 ` [Qemu-devel] [PATCH v2 1/6] hypertrace: Add documentation Lluís Vilanova
2016-09-05 18:56 ` [Qemu-devel] [PATCH v2 2/6] hypertrace: Add tracing event "guest_hypertrace" Lluís Vilanova
2016-09-05 18:56 ` [Qemu-devel] [PATCH v2 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event Lluís Vilanova
2016-09-05 18:56 ` [Qemu-devel] [PATCH v2 4/6] hypertrace: [softmmu] " Lluís Vilanova
2016-09-06  1:43   ` Michael S. Tsirkin
2016-09-09 13:19     ` Lluís Vilanova
2016-09-14 14:37     ` Stefan Hajnoczi
2016-09-05 18:56 ` [Qemu-devel] [PATCH v2 5/6] hypertrace: Add guest-side user-level library Lluís Vilanova
2016-09-05 18:56 ` [Qemu-devel] [PATCH v2 6/6] hypertrace: Add guest-side Linux module Lluís Vilanova
2016-09-05 19:23 ` [Qemu-devel] [PATCH v2 0/6] hypertrace: Lightweight guest-to-QEMU trace channel no-reply
2016-09-06  9:11   ` [Qemu-devel] Checkpatch false positives (Was: Re: [PATCH v2 0/6] hypertrace: Lightweight guest-to-QEMU trace channel) Lluís Vilanova
2016-09-06  9:16     ` Paolo Bonzini
2016-09-06 10:19       ` Lluís Vilanova [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpip8h62.fsf@fimbulvetr.bsc.es \
    --to=vilanova@ac.upc.edu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.