From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNxJW-0007tI-4n for qemu-devel@nongnu.org; Fri, 15 Jul 2016 03:13:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNxJQ-0000By-KW for qemu-devel@nongnu.org; Fri, 15 Jul 2016 03:13:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNxJQ-0000Br-Dk for qemu-devel@nongnu.org; Fri, 15 Jul 2016 03:13:28 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B030E7F7BA for ; Fri, 15 Jul 2016 07:13:27 +0000 (UTC) From: Markus Armbruster References: <1468468228-27827-1-git-send-email-eblake@redhat.com> <87mvlkkw6x.fsf@dusky.pond.sub.org> Date: Fri, 15 Jul 2016 09:13:25 +0200 In-Reply-To: <87mvlkkw6x.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Thu, 14 Jul 2016 18:42:46 +0200") Message-ID: <87wpknidbe.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH for-2.7 v9 00/17] qapi netdev_add introspection (post-introspection cleanups subset F) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org Markus Armbruster writes: > Eric Blake writes: > >> It's time to expose QMP 'netdev_add' through introspection, and >> to add boxed commands/events so that we can drastically reduce >> the number of C parameters needed to implement a command that >> matches a large QAPI type. >> >> Prerequistes: >> Markus' qapi-next branch (weak; series also applies on master) >> >> available as a tag at: >> git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv9f >> or as part of my qapi branch: >> git fetch git://repo.or.cz/qemu/ericb.git qapi >> >> v8 was here: >> https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00302.html >> >> Since then, I've addressed Markus' comments: >> - s/box/boxed/ >> - fix a useless Python override of c_name() >> - comment and formatting tweaks >> - defer event collision prevention until later; for 2.7, we are >> focusing on the bare minimum needed to take advantage of boxing >> - implement a promised followup that allows netdev_add to still >> parse strings the way it did with QemuOpts (thanks Dan for starting >> that effort) >> >> The diffstat from v8 looks big, but a lot of it is mechanical >> due to the spelling change. It's late at night, and we're close >> to hard freeze, so to maximize review time I'm posting now; if I >> weren't feeling quite as rushed, I might would have swapped the >> order of 14 vs. 15-17 to avoid even a temporary behavior change >> in netdev_add. On the other hand, 14 has had review, while 15-17 >> are effectively new, and it is feasible that we may be comfortable >> enough with the new type-safety constraints of 14 to not want >> to bother with 15-17 loosening things back up, given that we are >> already in soft freeze. > > PATCH 01-13 with the few overlooked instanced of 'box' corrected: > Reviewed-by: Markus Armbruster Pushed to qapi-next with PATCH 11 replaced by your update. > PATCH 14-17 need careful consideration. It's very late in the cycle, > which means there's little time to correct mistakes before they become > ABI. Risks upsetting the release with last minute corrections. Pushed to qapi-not-next for now. > The safest option is to punt to the next cycle. Would be a shame, > though. > > I need to read your discussion of the backward compatibility patches, > and the patches themselves, carefully.