From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60686)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bGMCy-0001bo-Nf
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:11:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bGMCs-0000fG-Vh
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:11:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56973)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bGMCs-0000f7-Q1
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:11:18 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 754BA385E
	for <qemu-devel@nongnu.org>; Fri, 24 Jun 2016 08:11:18 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1466698330-6021-1-git-send-email-armbru@redhat.com>
	<1466698330-6021-3-git-send-email-armbru@redhat.com>
	<576C3978.9040304@redhat.com>
Date: Fri, 24 Jun 2016 10:11:16 +0200
In-Reply-To: <576C3978.9040304@redhat.com> (Eric Blake's message of "Thu, 23
	Jun 2016 13:33:12 -0600")
Message-ID: <87wplfxazf.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC 2/5] tests: New make target
 check-headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com

Eric Blake <eblake@redhat.com> writes:

> On 06/23/2016 10:12 AM, Markus Armbruster wrote:
>> For each header "FOO.h", the test checks whether
>> 
>> 	#include "qemu/osdep.h"
>> 	#include "FOO.h"
>> 	#include "FOO.h"
>> 
>> compiles.  A large number of headers don't pass this test, by design
>> or by accident.  These are all excluded with a blacklist for now.  Add
>> make target check-blacklisted-headers to help with examinating how
>
> s/examinating/examining/
>
>> they fail.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  tests/Makefile.include | 426 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 426 insertions(+)
>> 
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index a2ed83b..e20f437 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -413,6 +413,421 @@ test-obj-y = tests/check-qint.o tests/check-qstring.o tests/check-qdict.o \
>>  $(test-obj-y): QEMU_INCLUDES += -Itests
>>  QEMU_CFLAGS += -I$(SRC_PATH)/tests
>>  
>> +# All headers
>> +headers := $(filter %.h, $(shell cd $(SRC_PATH) && git ls-files) $(GENERATED_HEADERS))
>
> Hard-coded to only work on a git checkout, but I guess that's okay.

I'll mention it in the commit message.