From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/2] drm/dsi: Implement dcs backlight brightness Date: Mon, 06 Jun 2016 21:04:36 +0300 Message-ID: <87wpm26vnv.fsf@intel.com> References: <1464832099-22402-1-git-send-email-simhavcs@gmail.com> <1464832099-22402-2-git-send-email-simhavcs@gmail.com> <87eg8a7opg.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 40B0B6E623 for ; Mon, 6 Jun 2016 18:04:42 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vinay Simha Cc: open list , "open list:DRM DRIVERS" , Archit Taneja List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwNiBKdW4gMjAxNiwgVmluYXkgU2ltaGEgPHNpbWhhdmNzQGdtYWlsLmNvbT4gd3Jv dGU6Cj4gT24gTW9uLCBKdW4gNiwgMjAxNiBhdCAxOjA3IFBNLCBKYW5pIE5pa3VsYSA8amFuaS5u aWt1bGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4gT24gVGh1LCAwMiBKdW4gMjAxNiwgVmlu YXkgU2ltaGEgQk4gPHNpbWhhdmNzQGdtYWlsLmNvbT4gd3JvdGU6Cj4+PiBQcm92aWRlIGEgc21h bGwgY29udmVuaWVuY2Ugd3JhcHBlciB0aGF0IHNldC9nZXQgdGhlCj4+PiBiYWNrbGlnaHQgYnJp Z2h0bmVzcyBjb250cm9sIGFuZCBjcmVhdGVzIHRoZSBiYWNrbGlnaHQKPj4+IGRldmljZSBmb3Ig dGhlIHBhbmVsIGludGVyZmFjZQo+Pgo+PiBUbyBiZSBwZWRhbnRpYywgd2Ugc2hvdWxkIGRvd25w bGF5ICJiYWNrbGlnaHQiIGluIHRoZSBEU0kgRENTIGJyaWdodG5lc3MKPj4gY29udHJvbC4uLiB0 aGVyZSBuZWVkIG5vdCBiZSBhIGJhY2tsaWdodCwgYXQgYWxsLCBmb3IgYnJpZ2h0bmVzcyBjb250 cm9sCj4+IChzZWUgQU1PTEVEKS4KPiBidXQgdGhpcyBqZGkgZGlzcGxheSBhbmQgZmV3IG90aGVy IGRzaSBkaXNwbGF5IGNhbiBiZSBjb250cm9sbGVkIGJ5Cj4gZGNzIGNvbW1hbmRzCgpUaGUgcG9p bnQgSSB3YXMgdHJ5aW5nIHRvIGNvbnZleSB3YXMgdGhhdCB0aGUgRFNJIERDUyBpbnRlcmZhY2Ug aXMKYWdub3N0aWMgdG8gdGhlIGFjdHVhbCBtZXRob2Qgb2YgY29udHJvbGxpbmcgYnJpZ2h0bmVz cy4gV2hldGhlciB0aGUKcGFuZWwgaGFzIGEgYmFja2xpZ2h0IHRvIGNvbnRyb2wgYnJpZ2h0bmVz cyBpcyBhIHBhbmVsIGltcGxlbWVudGF0aW9uCmRldGFpbC4gU28gbWF5YmUgd2Ugc2hvdWxkbid0 IGhhdmUgImJhY2tsaWdodCIgaW4gdGhlIGludGVyZmFjZQpub21lbmNsYXR1cmUgZWl0aGVyLgoK QlIsCkphbmkuCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kg Q2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbcFFSFE (ORCPT ); Mon, 6 Jun 2016 14:05:04 -0400 Received: from mga04.intel.com ([192.55.52.120]:11714 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbcFFSFB (ORCPT ); Mon, 6 Jun 2016 14:05:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,428,1459839600"; d="scan'208";a="996344677" From: Jani Nikula To: Vinay Simha Cc: open list , "open list\:DRM DRIVERS" , Archit Taneja , Rob Clark , Thierry Reding Subject: Re: [PATCH 2/2] drm/dsi: Implement dcs backlight brightness In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1464832099-22402-1-git-send-email-simhavcs@gmail.com> <1464832099-22402-2-git-send-email-simhavcs@gmail.com> <87eg8a7opg.fsf@intel.com> User-Agent: Notmuch/0.22+9~g73339ad (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 06 Jun 2016 21:04:36 +0300 Message-ID: <87wpm26vnv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Jun 2016, Vinay Simha wrote: > On Mon, Jun 6, 2016 at 1:07 PM, Jani Nikula wrote: >> On Thu, 02 Jun 2016, Vinay Simha BN wrote: >>> Provide a small convenience wrapper that set/get the >>> backlight brightness control and creates the backlight >>> device for the panel interface >> >> To be pedantic, we should downplay "backlight" in the DSI DCS brightness >> control... there need not be a backlight, at all, for brightness control >> (see AMOLED). > but this jdi display and few other dsi display can be controlled by > dcs commands The point I was trying to convey was that the DSI DCS interface is agnostic to the actual method of controlling brightness. Whether the panel has a backlight to control brightness is a panel implementation detail. So maybe we shouldn't have "backlight" in the interface nomenclature either. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center