From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mpg123: unbreak static linking with alsa/portaudio
Date: Tue, 24 May 2016 20:46:33 +0200 [thread overview]
Message-ID: <87wpmjb8fq.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20160524204107.570fbb64@free-electrons.com> (Thomas Petazzoni's message of "Tue, 24 May 2016 20:41:07 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Hello,
> On Tue, 24 May 2016 19:59:05 +0200, Peter Korsgaard wrote:
>> Fixes:
>> http://autobuild.buildroot.org/results/b2b/b2bc143fbd0b34e75a44af41ab6899dd9fa3c21a/
>> http://autobuild.buildroot.org/results/60d/60d56b0a75d209f2cfeff0727c2f900abc89d263/
>> http://autobuild.buildroot.org/results/6a8/6a8729ce69055821fdf0b91adcea2ea201d40189/
>>
>> And many more.
>>
>> A recent upstream build system change caused LIBS to be ignored at build
>> time (but still used a configure time), causing our static linking
>> workarounds to no longer work.
>>
>> Fix it by adding a patch to cause it to no longer ignore LIBS.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> It would be so much better to use pkg-config, especially since they
> already use PKG_CHECK_MODULES() in their configure script to detect
> other packages.
Agreed, but I wanted as minimalistic as possible fix for 2016.05.
--
Venlig hilsen,
Peter Korsgaard
next prev parent reply other threads:[~2016-05-24 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 17:59 [Buildroot] [PATCH] mpg123: unbreak static linking with alsa/portaudio Peter Korsgaard
2016-05-24 18:41 ` Thomas Petazzoni
2016-05-24 18:46 ` Peter Korsgaard [this message]
2016-05-25 5:45 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpmjb8fq.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.