All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Patrick Uiterwijk <patrick@puiterwijk.org>,
	linux@roeck-us.net, davem@davemloft.net, netdev@vger.kernel.org,
	dennis@ausil.us, pbrobinson@gmail.com
Subject: Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup
Date: Tue, 29 Mar 2016 14:49:57 -0400	[thread overview]
Message-ID: <87wpolgluy.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <20160329162825.GC4690@lunn.ch>

Hi Andrew, Patrick,

Andrew Lunn <andrew@lunn.ch> writes:

> On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote:
>> Hi Patrick,
>> 
>> Two comments below.
>> 
>> Patrick Uiterwijk <patrick@puiterwijk.org> writes:
>> 
>> > +static int mv88e6xxx_power_on_serdes(struct dsa_switch *ds)
>> 
>> Since this function assumes the SMI lock is already held, its name
>> should be prefixed with _ by convention (_mv88e6xxx_power_on_serdes).
>
> We decided to drop at, since nearly everything would end up with a _
> prefix. The assert_smi_lock() should find any missing locks, and
> lockdep/deadlocks will make it clear when the lock is taken twice.

OK, I didn't know that. This makes sense. There is no need to respin a
v3 only for my previous &= comment then.

Thanks,
-v

  reply	other threads:[~2016-03-29 18:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 11:11 [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write} Patrick Uiterwijk
2016-03-29 11:11 ` [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup Patrick Uiterwijk
2016-03-29 16:23   ` Vivien Didelot
2016-03-29 16:28     ` Andrew Lunn
2016-03-29 18:49       ` Vivien Didelot [this message]
2016-03-30  0:58         ` Patrick Uiterwijk
2016-03-30  1:02           ` Andrew Lunn
2016-03-29 16:26 ` [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write} Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpolgluy.fsf@ketchup.mtl.sfl \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dennis@ausil.us \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    --cc=patrick@puiterwijk.org \
    --cc=pbrobinson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.