From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: OpenBMC Patches <openbmc-patches@stwcx.xyz>, openbmc@lists.ozlabs.org
Subject: Re: [PATCH phosphor-host-ipmid] IPMI Get IP Support
Date: Thu, 11 Feb 2016 14:56:49 +1100 [thread overview]
Message-ID: <87wpqbq4qm.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455134445-29477-2-git-send-email-openbmc-patches@stwcx.xyz>
OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:
> + while (digit != NULL)
> + {
> + int resp_byte = strtoul(digit, NULL, 10);
> + memcpy((void*)&buf[i+1], &resp_byte, 1);
memcpy here? Really?
--
Stewart Smith
OPAL Architect, IBM.
prev parent reply other threads:[~2016-02-11 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 20:00 [PATCH phosphor-host-ipmid] IPMI Get IP Support OpenBMC Patches
2016-02-10 20:00 ` OpenBMC Patches
2016-02-11 3:56 ` Stewart Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpqbq4qm.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=openbmc-patches@stwcx.xyz \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.