From: Felipe Balbi <balbi@kernel.org>
To: Bin Liu <b-liu@ti.com>, Arnd Bergmann <arnd@arndb.de>
Cc: Felipe Balbi <balbi@ti.com>,
balbif@gmail.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency
Date: Wed, 03 Feb 2016 19:54:02 +0200 [thread overview]
Message-ID: <87wpqlptmt.fsf@ti.com> (raw)
In-Reply-To: <20160120180833.GA5433@uda0271908>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
hi,
Bin Liu <b-liu@ti.com> writes:
> On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote:
>> The phy-am335x driver accidentally selects 'USB_COMMON', which is
>> not correct as that symbol should indicate whether USB host or
>> target mode is enabled, but it might not:
>>
>> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
>
> Is it possible to have a .config which has either USB nor USB_GADGET
> set but AM335X_PHY_USB is set to be in the situation as in the warning
> above?
>
>>
>> This changes the 'select' into 'depends on', as it should have
>> been initially.
>
> Using 'depends on' causes AM335x_PHY_USB driver unable to built-in,
> since USB_COMMON is an invisible option and its defualt is 'M'.
yeah, USB_COMMON is supposed to be selected, not depended upon.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-02-03 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:56 [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Arnd Bergmann
2016-01-20 18:08 ` Bin Liu
2016-02-03 17:54 ` Felipe Balbi [this message]
2016-02-03 21:08 ` Arnd Bergmann
2016-02-03 22:04 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpqlptmt.fsf@ti.com \
--to=balbi@kernel.org \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=balbi@ti.com \
--cc=balbif@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.