From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQZWk-0003gS-2m for qemu-devel@nongnu.org; Tue, 02 Feb 2016 06:53:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQZWf-0007Tt-8a for qemu-devel@nongnu.org; Tue, 02 Feb 2016 06:53:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQZWf-0007Tm-3G for qemu-devel@nongnu.org; Tue, 02 Feb 2016 06:53:41 -0500 From: Markus Armbruster References: <1454343639-9020-1-git-send-email-marcandre.lureau@redhat.com> <1454343639-9020-7-git-send-email-marcandre.lureau@redhat.com> <878u33v7bx.fsf@blackfin.pond.sub.org> <1255030269.15293079.1454408652071.JavaMail.zimbra@redhat.com> Date: Tue, 02 Feb 2016 12:53:38 +0100 In-Reply-To: <1255030269.15293079.1454408652071.JavaMail.zimbra@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 2 Feb 2016 05:24:12 -0500 (EST)") Message-ID: <87wpqnnxa5.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 6/8] ivshmem: generalize ivshmem_setup_interrupts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: marcandre lureau , claudio fontana , qemu-devel@nongnu.org Marc-Andr=C3=A9 Lureau writes: > Hi > > ----- Original Message ----- >> marcandre.lureau@redhat.com writes: >>=20 >> > From: Marc-Andr=C3=A9 Lureau >> > >> > Call ivshmem_setup_interrupts() with or without MSI, always allocate >> > msi_vectors that is going to be used in all case in the following patc= h. >> > >> > Signed-off-by: Marc-Andr=C3=A9 Lureau >> > --- >> > hw/misc/ivshmem.c | 26 ++++++++++++++++---------- >> > 1 file changed, 16 insertions(+), 10 deletions(-) >> > >> > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c >> > index 5029789..c601a8a 100644 >> > --- a/hw/misc/ivshmem.c >> > +++ b/hw/misc/ivshmem.c >> > @@ -769,18 +769,25 @@ static void ivshmem_reset(DeviceState *d) >> > ivshmem_use_msix(s); >> > } >> >=20=20 >> > -static int ivshmem_setup_msi(IVShmemState * s) >> > +static int ivshmem_setup_interrupts(IVShmemState *s) >> > { >> > - if (msix_init_exclusive_bar(PCI_DEVICE(s), s->vectors, 1)) { >> > - return -1; >> > + /* allocate QEMU callback data for receiving interrupts */ >> > + if (s->vectors > 0) { >> > + s->msi_vectors =3D g_malloc0(s->vectors * sizeof(MSIVector)); >> > + if (!s->msi_vectors) { >>=20 >> Can't happen; s->vectors * sizeof(MSIVector) !=3D 0. > > It can't happen on allocation failure? Nope. Compare g_malloc0() and g_try_malloc0() at https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html We generally use the "try" variants only for memory allocations that can execute during operation and can be "big".