From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK0d0-0006H2-01 for qemu-devel@nongnu.org; Fri, 15 Jan 2016 04:25:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK0cy-0004ym-T5 for qemu-devel@nongnu.org; Fri, 15 Jan 2016 04:25:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK0cy-0004yY-OS for qemu-devel@nongnu.org; Fri, 15 Jan 2016 04:25:04 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 60C83345B25 for ; Fri, 15 Jan 2016 09:25:03 +0000 (UTC) From: Markus Armbruster References: <1452784405-7097-1-git-send-email-armbru@redhat.com> <5697CF32.9090108@redhat.com> Date: Fri, 15 Jan 2016 10:25:01 +0100 In-Reply-To: <5697CF32.9090108@redhat.com> (Eric Blake's message of "Thu, 14 Jan 2016 09:39:14 -0700") Message-ID: <87wprb42ky.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org Eric Blake writes: > On 01/14/2016 08:13 AM, Markus Armbruster wrote: >> The implicit tag member is named "type", not "kind". Screwed up in >> commit 39a1815. >> >> Signed-off-by: Markus Armbruster >> --- >> docs/qapi-code-gen.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Eric Blake > > However, there's other errors in the documentation (we haven't kept it > up-to-date with recent churn in the generator), so maybe it's better to > fix all of them at once. See my Subset E series: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html > https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00410.html Feel free to fold my patch into yours. > (I'll probably have to send a v9 of the series, but wanted to see if you > had any comments on v8 first) In my review queue.