From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58334)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZuKAH-0003zS-Ew
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 08:01:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZuKAB-0007dK-RR
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 08:01:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36496)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZuKAB-0007d8-N5
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 08:01:11 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <cover.1446714761.git.v.maffione@gmail.com>
	<cover.1446714761.git.v.maffione@gmail.com>
	<911665eb3158159da19e7bf1c931f6311a246be9.1446714761.git.v.maffione@gmail.com>
Date: Thu, 05 Nov 2015 14:01:05 +0100
In-Reply-To: <911665eb3158159da19e7bf1c931f6311a246be9.1446714761.git.v.maffione@gmail.com>
	(Vincenzo Maffione's message of "Thu, 5 Nov 2015 10:35:40 +0100")
Message-ID: <87wptwvbvy.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vincenzo Maffione <v.maffione@gmail.com>
Cc: rizzo@iet.unipi.it, jasowang@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, g.lettieri@iet.unipi.it

Vincenzo Maffione <v.maffione@gmail.com> writes:

> Reorganization of struct NetClientOptions caused a compilation failure
> of the netmap backend. This patch fixes the issue by properly accessing the
> union field.
>
> Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
> ---
>  net/netmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netmap.c b/net/netmap.c
> index 508b829..4197a9c 100644
> --- a/net/netmap.c
> +++ b/net/netmap.c
> @@ -439,7 +439,7 @@ int net_init_netmap(const NetClientOptions *opts,
>                      const char *name, NetClientState *peer, Error **errp)
>  {
>      /* FIXME error_setg(errp, ...) on failure */
> -    const NetdevNetmapOptions *netmap_opts = opts->netmap;
> +    const NetdevNetmapOptions *netmap_opts = opts->u.netmap;
>      NetClientState *nc;
>      NetmapPriv me;
>      NetmapState *s;

Broken in commit e4ba22b.  Recommend to point to that in the commit
message.  Thanks for cleaning up the mess we made there!

Reviewed-by: Markus Armbruster <armbru@redhat.com>