From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjrMz-0004TX-9i for qemu-devel@nongnu.org; Wed, 07 Oct 2015 12:15:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjrMw-00028m-3E for qemu-devel@nongnu.org; Wed, 07 Oct 2015 12:15:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjrMv-00027j-VU for qemu-devel@nongnu.org; Wed, 07 Oct 2015 12:15:06 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6345DAC7C6 for ; Wed, 7 Oct 2015 16:15:05 +0000 (UTC) From: Markus Armbruster References: <1443930073-19359-1-git-send-email-eblake@redhat.com> <1443930073-19359-4-git-send-email-eblake@redhat.com> Date: Wed, 07 Oct 2015 18:15:02 +0200 In-Reply-To: <1443930073-19359-4-git-send-email-eblake@redhat.com> (Eric Blake's message of "Sat, 3 Oct 2015 21:41:02 -0600") Message-ID: <87wpuywt89.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com Eric Blake writes: > The alternate-good.json test was already covered by > qapi-schema-test.json. As future commits will be tweaking > how alternates are laid out, removing the duplicate test now > reduces churn. Do we have more positive tests? They should probably all live in qapi-schema-test.json, because there their generated code actually gets compiled. Patch looks good.