From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ne: Add h8300 support.
Date: Fri, 02 Oct 2015 15:04:25 +0900 [thread overview]
Message-ID: <87wpv5q00m.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20150927.125130.1749145249599569463.davem@davemloft.net>
On Mon, 28 Sep 2015 04:51:30 +0900,
David Miller wrote:
>
> From: Yoshinori Sato <ysato@users.sourceforge.jp>
> Date: Sun, 27 Sep 2015 23:19:15 +0900
>
> > @@ -88,7 +88,7 @@ config MCF8390
> > config NE2000
> > tristate "NE2000/NE1000 support"
> > depends on (ISA || (Q40 && m) || M32R || MACH_TX49XX || \
> > - ATARI_ETHERNEC)
> > + ATARI_ETHERNEC || H8300)
> ...
> >
> > -#if defined(CONFIG_PLAT_MAPPI) || defined(CONFIG_PLAT_OAKS32R)
> > +#if defined(CONFIG_PLAT_MAPPI) || defined(CONFIG_PLAT_OAKS32R) || \
> > + defined(CONFIG_H8300_KANEBEBE) || defined(CONFIG_H8300_AE3069)
>
> It makes no sense to test different config symbols for these two
> things.
>
> Either both should use "H8300" or both should use
> "H8300_KANEBEBE || H8300_AE3069".
OK.
I'll sent v2.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
prev parent reply other threads:[~2015-10-02 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 14:19 [PATCH 1/2] ne: Add h8300 support Yoshinori Sato
2015-09-27 14:19 ` [PATCH 2/2] ne: DeviceTree support Yoshinori Sato
2015-09-27 19:51 ` [PATCH 1/2] ne: Add h8300 support David Miller
2015-10-02 6:04 ` Yoshinori Sato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpv5q00m.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.