From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH] arm64: KVM: Fix user access for debug registers Date: Wed, 16 Sep 2015 15:35:55 +0100 Message-ID: <87wpvqmnxw.fsf@linaro.org> References: <1442400070-23316-1-git-send-email-marc.zyngier@arm.com> <20150916134141.GA15903@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 82E0C41450 for ; Wed, 16 Sep 2015 10:35:02 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cEJmMcQXwdfn for ; Wed, 16 Sep 2015 10:34:58 -0400 (EDT) Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9170F412ED for ; Wed, 16 Sep 2015 10:34:58 -0400 (EDT) Received: by wiclk2 with SMTP id lk2so74074918wic.1 for ; Wed, 16 Sep 2015 07:35:57 -0700 (PDT) In-reply-to: <20150916134141.GA15903@cbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Christoffer Dall Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org List-Id: kvmarm@lists.cs.columbia.edu CkNocmlzdG9mZmVyIERhbGwgPGNocmlzdG9mZmVyLmRhbGxAbGluYXJvLm9yZz4gd3JpdGVzOgoK PiBPbiBXZWQsIFNlcCAxNiwgMjAxNSBhdCAxMTo0MToxMEFNICswMTAwLCBNYXJjIFp5bmdpZXIg d3JvdGU6Cj4+IFdoZW4gc2V0dGluZyB0aGUgZGVidWcgcmVnaXN0ZXIgZnJvbSB1c2Vyc3BhY2Us IG1ha2Ugc3VyZSB0aGF0Cj4+IGNvcHlfZnJvbV91c2VyKCkgaXMgY2FsbGVkIHdpdGggaXRzIHBh cmFtZXRlcnMgaW4gdGhlIGV4cGVjdGVkCj4+IG9yZGVyLiBJdCBvdGhlcndpc2UgZG9lc24ndCBk byB3aGF0IHlvdSB0aGluay4KPj4gCj4+IFJlcG9ydGVkLWJ5OiBQZXRlciBNYXlkZWxsIDxwZXRl ci5tYXlkZWxsQGxpbmFyby5vcmc+Cj4+IENjOiBBbGV4IEJlbm7DqWUgPGFsZXguYmVubmVlQGxp bmFyby5vcmc+Cj4+IEZpeGVzOiA4NGU2OTBiZmJlZDEgKCJLVk06IGFybTY0OiBpbnRyb2R1Y2Ug dmNwdS0+YXJjaC5kZWJ1Z19wdHIiKQo+PiBTaWduZWQtb2ZmLWJ5OiBNYXJjIFp5bmdpZXIgPG1h cmMuenluZ2llckBhcm0uY29tPgo+Cj4geWlrZXMhCgpPSyBJJ20gbm93IG11Y2hseSBjb25mdXNl ZCBhcyB0byBob3cgaXQgY291bGQgaGF2ZSB3b3JrZWQuLi4KCj4KPiBSZXZpZXdlZC1ieTogQ2hy aXN0b2ZmZXIgRGFsbCA8Y2hyaXN0b2ZmZXIuZGFsbEBsaW5hcm8ub3JnPgoKLS0gCkFsZXggQmVu bsOpZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1h cm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0 cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: alex.bennee@linaro.org (Alex =?utf-8?Q?Benn=C3=A9e?=) Date: Wed, 16 Sep 2015 15:35:55 +0100 Subject: [PATCH] arm64: KVM: Fix user access for debug registers In-Reply-To: <20150916134141.GA15903@cbox> References: <1442400070-23316-1-git-send-email-marc.zyngier@arm.com> <20150916134141.GA15903@cbox> Message-ID: <87wpvqmnxw.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Christoffer Dall writes: > On Wed, Sep 16, 2015 at 11:41:10AM +0100, Marc Zyngier wrote: >> When setting the debug register from userspace, make sure that >> copy_from_user() is called with its parameters in the expected >> order. It otherwise doesn't do what you think. >> >> Reported-by: Peter Maydell >> Cc: Alex Benn?e >> Fixes: 84e690bfbed1 ("KVM: arm64: introduce vcpu->arch.debug_ptr") >> Signed-off-by: Marc Zyngier > > yikes! OK I'm now muchly confused as to how it could have worked... > > Reviewed-by: Christoffer Dall -- Alex Benn?e