From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in i915_gem_gtt.c Date: Wed, 16 Sep 2015 17:08:22 +0300 Message-ID: <87wpvqtq21.fsf@intel.com> References: <6d965fc0ee156ffa54de676203e9265939ea698e.1442350180.git.geliangtang@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <6d965fc0ee156ffa54de676203e9265939ea698e.1442350180.git.geliangtang@163.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxNSBTZXAgMjAxNSwgR2VsaWFuZyBUYW5nIDxnZWxpYW5ndGFuZ0AxNjMuY29tPiB3 cm90ZToKPiBGaXggdGhlIGZvbGxvd2luZyAnbWFrZSBodG1sZG9jcycgd2FybmluZ3M6Cj4KPiAg IC4vL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jOjc1ODogd2FybmluZzogTm8g ZGVzY3JpcHRpb24gZm91bmQgZm9yIHBhcmFtZXRlciAnbGVuZ3RoJwo+ICAgLi8vZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmM6ODE4OiB3YXJuaW5nOiBObyBkZXNjcmlwdGlvbiBm b3VuZCBmb3IgcGFyYW1ldGVyICdsZW5ndGgnCj4gICAuLy9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9ndHQuYzo4MTg6IHdhcm5pbmc6IE5vIGRlc2NyaXB0aW9uIGZvdW5kIGZvciBwYXJh bWV0ZXIgJ25ld19wZHMnCj4gICAuLy9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQu Yzo3NTg6IHdhcm5pbmc6IE5vIGRlc2NyaXB0aW9uIGZvdW5kIGZvciBwYXJhbWV0ZXIgJ2xlbmd0 aCcKPiAgIC4vL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jOjgxODogd2Fybmlu ZzogTm8gZGVzY3JpcHRpb24gZm91bmQgZm9yIHBhcmFtZXRlciAnbGVuZ3RoJwo+ICAgLi8vZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmM6ODE4OiB3YXJuaW5nOiBObyBkZXNjcmlw dGlvbiBmb3VuZCBmb3IgcGFyYW1ldGVyICduZXdfcGRzJwoKVGhlc2UgYXJlIGFscmVhZHkgZml4 ZWQgYnkKCmNvbW1pdCBkNGVjOWRhMGUxN2NiNmE4NmMwYjc2YzViMjU0OTgxNjAxZDI1MDMxCkF1 dGhvcjogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KRGF0ZTogICBU aHUgSnVsIDMwIDExOjAyOjAzIDIwMTUgKzAxMDAKCiAgICBkcm0vaTkxNS9nZW44OiBBYnN0cmFj dCBQRFAgdXNhZ2UKClRoYW5rcywKSmFuaS4KCgo+Cj4gU2lnbmVkLW9mZi1ieTogR2VsaWFuZyBU YW5nIDxnZWxpYW5ndGFuZ0AxNjMuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9ndHQuYyB8IDYgKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMo KyksIDMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IGlu ZGV4IDk2MDU0YTUuLmMwNzBhMWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZ3R0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQu Ywo+IEBAIC03MzcsNyArNzM3LDcgQEAgc3RhdGljIHZvaWQgZ2VuOF9wcGd0dF9jbGVhbnVwKHN0 cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtKQo+ICAgKiBAcHBndHQ6CU1hc3RlciBwcGd0dCBz dHJ1Y3R1cmUuCj4gICAqIEBwZDoJCVBhZ2UgZGlyZWN0b3J5IGZvciB0aGlzIGFkZHJlc3MgcmFu Z2UuCj4gICAqIEBzdGFydDoJU3RhcnRpbmcgdmlydHVhbCBhZGRyZXNzIHRvIGJlZ2luIGFsbG9j YXRpb25zLgo+IC0gKiBAbGVuZ3RoCVNpemUgb2YgdGhlIGFsbG9jYXRpb25zLgo+ICsgKiBAbGVu Z3RoOglTaXplIG9mIHRoZSBhbGxvY2F0aW9ucy4KPiAgICogQG5ld19wdHM6CUJpdG1hcCBzZXQg YnkgZnVuY3Rpb24gd2l0aCBuZXcgYWxsb2NhdGlvbnMuIExpa2VseSB1c2VkIGJ5IHRoZQo+ICAg KgkJY2FsbGVyIHRvIGZyZWUgb24gZXJyb3IuCj4gICAqCj4gQEAgLTc5Miw4ICs3OTIsOCBAQCB1 bndpbmRfb3V0Ogo+ICAgKiBAcHBndHQ6CU1hc3RlciBwcGd0dCBzdHJ1Y3R1cmUuCj4gICAqIEBw ZHA6CVBhZ2UgZGlyZWN0b3J5IHBvaW50ZXIgZm9yIHRoaXMgYWRkcmVzcyByYW5nZS4KPiAgICog QHN0YXJ0OglTdGFydGluZyB2aXJ0dWFsIGFkZHJlc3MgdG8gYmVnaW4gYWxsb2NhdGlvbnMuCj4g LSAqIEBsZW5ndGgJU2l6ZSBvZiB0aGUgYWxsb2NhdGlvbnMuCj4gLSAqIEBuZXdfcGRzCUJpdG1h cCBzZXQgYnkgZnVuY3Rpb24gd2l0aCBuZXcgYWxsb2NhdGlvbnMuIExpa2VseSB1c2VkIGJ5IHRo ZQo+ICsgKiBAbGVuZ3RoOglTaXplIG9mIHRoZSBhbGxvY2F0aW9ucy4KPiArICogQG5ld19wZHM6 CUJpdG1hcCBzZXQgYnkgZnVuY3Rpb24gd2l0aCBuZXcgYWxsb2NhdGlvbnMuIExpa2VseSB1c2Vk IGJ5IHRoZQo+ICAgKgkJY2FsbGVyIHRvIGZyZWUgb24gZXJyb3IuCj4gICAqCj4gICAqIEFsbG9j YXRlIHRoZSByZXF1aXJlZCBudW1iZXIgb2YgcGFnZSBkaXJlY3RvcmllcyBzdGFydGluZyBhdCB0 aGUgcGRlIGluZGV4IG9mCj4gLS0gCj4gMS45LjEKPgo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVs IE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbbIPOFq (ORCPT ); Wed, 16 Sep 2015 10:05:46 -0400 Received: from mga09.intel.com ([134.134.136.24]:42721 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752110AbbIPOFp (ORCPT ); Wed, 16 Sep 2015 10:05:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,539,1437462000"; d="scan'208";a="806426321" From: Jani Nikula To: Geliang Tang , Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in i915_gem_gtt.c In-Reply-To: <6d965fc0ee156ffa54de676203e9265939ea698e.1442350180.git.geliangtang@163.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <6d965fc0ee156ffa54de676203e9265939ea698e.1442350180.git.geliangtang@163.com> User-Agent: Notmuch/0.20.2+58~g39779b9 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 16 Sep 2015 17:08:22 +0300 Message-ID: <87wpvqtq21.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Sep 2015, Geliang Tang wrote: > Fix the following 'make htmldocs' warnings: > > .//drivers/gpu/drm/i915/i915_gem_gtt.c:758: warning: No description found for parameter 'length' > .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'length' > .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'new_pds' > .//drivers/gpu/drm/i915/i915_gem_gtt.c:758: warning: No description found for parameter 'length' > .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'length' > .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'new_pds' These are already fixed by commit d4ec9da0e17cb6a86c0b76c5b254981601d25031 Author: Michel Thierry Date: Thu Jul 30 11:02:03 2015 +0100 drm/i915/gen8: Abstract PDP usage Thanks, Jani. > > Signed-off-by: Geliang Tang > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > index 96054a5..c070a1f 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -737,7 +737,7 @@ static void gen8_ppgtt_cleanup(struct i915_address_space *vm) > * @ppgtt: Master ppgtt structure. > * @pd: Page directory for this address range. > * @start: Starting virtual address to begin allocations. > - * @length Size of the allocations. > + * @length: Size of the allocations. > * @new_pts: Bitmap set by function with new allocations. Likely used by the > * caller to free on error. > * > @@ -792,8 +792,8 @@ unwind_out: > * @ppgtt: Master ppgtt structure. > * @pdp: Page directory pointer for this address range. > * @start: Starting virtual address to begin allocations. > - * @length Size of the allocations. > - * @new_pds Bitmap set by function with new allocations. Likely used by the > + * @length: Size of the allocations. > + * @new_pds: Bitmap set by function with new allocations. Likely used by the > * caller to free on error. > * > * Allocate the required number of page directories starting at the pde index of > -- > 1.9.1 > > -- Jani Nikula, Intel Open Source Technology Center