From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAFuY-0002pd-JW for qemu-devel@nongnu.org; Wed, 01 Jul 2015 07:10:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAFuU-0002ph-HT for qemu-devel@nongnu.org; Wed, 01 Jul 2015 07:10:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAFuU-0002pZ-Am for qemu-devel@nongnu.org; Wed, 01 Jul 2015 07:10:34 -0400 From: Juan Quintela In-Reply-To: <5593BF0B.1010804@de.ibm.com> (Christian Borntraeger's message of "Wed, 01 Jul 2015 12:20:59 +0200") References: <1435742217-62246-1-git-send-email-borntraeger@de.ibm.com> <87egks19rh.fsf@neno.neno> <5593BF0B.1010804@de.ibm.com> Date: Wed, 01 Jul 2015 13:10:32 +0200 Message-ID: <87wpykyvyv.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/1] s390x/migration: Introduce 2.4 machine Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Alexander Graf , qemu-devel , "Dr. David Alan Gilbert" , Jens Freimann , "Jason J. Herne" , Boris Fiuczynski , Cornelia Huck Christian Borntraeger wrote: > Am 01.07.2015 um 11:56 schrieb Juan Quintela: >> Christian Borntraeger wrote: >> >> First of all >> >> Reviewed-by: Juan Quintela >> >> For the patch. >> >> But one said that, I don't agree with the commint text. > > So let's just drop this sentence >>> While one can argue that section footer should be enabled >>> explicitely for new versions instead of disabled for old ones, > > And rephrase to > > " > This pinpoints to a problem of s390-ccw-machines: it needs to > be versioned to allow common code changes to add compat handling. > " > > > > Conny, want me to resend or can you fixup the patch description when > taking this patch? > >> >> >>> The section footer changes commit f68945d42bab ("Add a protective >>> section footer") and commit 37fb569c0198 ("Disable section footers >>> on older machine types") broke migration for any non-versioned >>> machines. >> >> If broke migration for 2.4 -> 2.3 for machines that don't care about >> compatibility. If they care, they are versioned O:-) Right now ppc & >> x86. I guess that s390 and arm will follow in due curse. > > yes. That is what my 2nd sentence says: we are not versioned and that is > the main issue to solve. You do it, so you are well. Thanks. >> was good for any reason, normal devices do changes, and then x86 try to >> fix the pieces after the fact. That is going to continue, just that now >> more architectures care, and then we should detect this kind of problems >> much earlier. >> >>> Let's introduce a version scheme for s390-ccw-virtio machines. >>> We will use the old s390-ccw-virtio name as alias to the latest >>> version as all existing libvirt XML for the ccw type were expanded >>> by libvirt to that name. >>> >>> The only downside of this patch is, that the old alias s390-ccw >>> will no longer be available as machines can have only one alias, >>> but it should not really matter. >> >> Should we change to a list? > > list of aliases? Why not, we would use it. Anyone for machine definitions reading this? More people need/wants it? Later, Juan