From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46476)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YyFYE-0004S6-Ng
	for qemu-devel@nongnu.org; Fri, 29 May 2015 04:21:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YyFYB-0003Ui-I7
	for qemu-devel@nongnu.org; Fri, 29 May 2015 04:21:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34896)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YyFYB-0003Ub-CR
	for qemu-devel@nongnu.org; Fri, 29 May 2015 04:21:55 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (Postfix) with ESMTPS id 0823C362081
	for <qemu-devel@nongnu.org>; Fri, 29 May 2015 08:21:55 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1432653655-30745-1-git-send-email-armbru@redhat.com>
	<20150528154257.16510723@redhat.com>
Date: Fri, 29 May 2015 10:21:52 +0200
In-Reply-To: <20150528154257.16510723@redhat.com> (Luiz Capitulino's message
	of "Thu, 28 May 2015 15:42:57 -0400")
Message-ID: <87wpzrlrof.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError,
	and other cleanups
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Tue, 26 May 2015 17:20:35 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Command handlers still use QError.  Left for another day.
>
> Great work! I've found one bug that has to be addressed before merging.
> Also, for the error conversions you're doing you're going from
> qerror_report() to error_set() but I'd recommend going directly to
> error_setg() as that's our final goal. It's totally fine with me
> if you're saving this work for a later series, but I think it will
> you save work if you do it in this series. Your call.

Saving for later, not least because this series has been fully reviewed
now.

> Can you take this through your tree?

Sure!

>                                      Feel free to add this once
> you fix the bug:
>
> Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

Thanks!