From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: drop drm_property_unreference_blob_locked() Date: Wed, 20 May 2015 10:09:59 +0300 Message-ID: <87wq03k9mg.fsf@intel.com> References: <1432035516-2909-1-git-send-email-sergey.senozhatsky@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id B7B446E6F7 for ; Wed, 20 May 2015 00:07:50 -0700 (PDT) In-Reply-To: <1432035516-2909-1-git-send-email-sergey.senozhatsky@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie Cc: Sergey Senozhatsky , Daniel Stone , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxOSBNYXkgMjAxNSwgU2VyZ2V5IFNlbm96aGF0c2t5IDxzZXJnZXkuc2Vub3poYXRz a3lAZ21haWwuY29tPiB3cm90ZToKPiBkcm1fcHJvcGVydHlfdW5yZWZlcmVuY2VfYmxvYl9sb2Nr ZWQoKSBpcyBzdGF0aWMgYW5kIHVudXNlZCwKPiBkcm9wIGl0LgoKaHR0cDovL21pZC5nbWFuZS5v cmcvQ0FQajg3ck1QdGFmZVlOemdYb1ArZngwZEFxaHdhRDdrZG5KZ3FiX3ZkYlB0aU9yWFBnQG1h aWwuZ21haWwuY29tCgo+Cj4gU2lnbmVkLW9mZi1ieTogU2VyZ2V5IFNlbm96aGF0c2t5IDxzZXJn ZXkuc2Vub3poYXRza3lAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Ny dGMuYyB8IDE5IC0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIGIvZHJp dmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBpbmRleCA0MDU5ZjA2Li42ZTYwZjcxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2RybV9jcnRjLmMKPiBAQCAtNDMxMywyNSArNDMxMyw2IEBAIHZvaWQgZHJtX3Byb3BlcnR5X3Vu cmVmZXJlbmNlX2Jsb2Ioc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICpibG9iKQo+ICBFWFBPUlRf U1lNQk9MKGRybV9wcm9wZXJ0eV91bnJlZmVyZW5jZV9ibG9iKTsKPiAgCj4gIC8qKgo+IC0gKiBk cm1fcHJvcGVydHlfdW5yZWZlcmVuY2VfYmxvYl9sb2NrZWQgLSBVbnJlZmVyZW5jZSBhIGJsb2Ig cHJvcGVydHkgd2l0aCBibG9iX2xvY2sgaGVsZAo+IC0gKgo+IC0gKiBEcm9wIGEgcmVmZXJlbmNl IG9uIGEgYmxvYiBwcm9wZXJ0eS4gTWF5IGZyZWUgdGhlIG9iamVjdC4gVGhpcyBtdXN0IGJlCj4g LSAqIGNhbGxlZCB3aXRoIGJsb2JfbG9jayBoZWxkLgo+IC0gKgo+IC0gKiBAcGFyYW0gZGV2ICBE ZXZpY2UgdGhlIGJsb2Igd2FzIGNyZWF0ZWQgb24KPiAtICogQHBhcmFtIGJsb2IgUG9pbnRlciB0 byBibG9iIHByb3BlcnR5Cj4gLSAqLwo+IC1zdGF0aWMgdm9pZCBkcm1fcHJvcGVydHlfdW5yZWZl cmVuY2VfYmxvYl9sb2NrZWQoc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICpibG9iKQo+IC17Cj4g LQlpZiAoIWJsb2IpCj4gLQkJcmV0dXJuOwo+IC0KPiAtCURSTV9ERUJVRygiJXA6IGJsb2IgSUQ6 ICVkICglZClcbiIsIGJsb2IsIGJsb2ItPmJhc2UuaWQsIGF0b21pY19yZWFkKCZibG9iLT5yZWZj b3VudC5yZWZjb3VudCkpOwo+IC0KPiAtCWtyZWZfcHV0KCZibG9iLT5yZWZjb3VudCwgZHJtX3By b3BlcnR5X2ZyZWVfYmxvYik7Cj4gLX0KPiAtCj4gLS8qKgo+ICAgKiBkcm1fcHJvcGVydHlfcmVm ZXJlbmNlX2Jsb2IgLSBUYWtlIGEgcmVmZXJlbmNlIG9uIGFuIGV4aXN0aW5nIHByb3BlcnR5Cj4g ICAqCj4gICAqIFRha2UgYSBuZXcgcmVmZXJlbmNlIG9uIGFuIGV4aXN0aW5nIGJsb2IgcHJvcGVy dHkuCj4gLS0gCj4gMi40LjEuMTY4LmcxZWEyOGUxCj4KPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVu IFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbbETHH6 (ORCPT ); Wed, 20 May 2015 03:07:58 -0400 Received: from mga11.intel.com ([192.55.52.93]:4851 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbbETHHv (ORCPT ); Wed, 20 May 2015 03:07:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,463,1427785200"; d="scan'208";a="728839547" From: Jani Nikula To: Sergey Senozhatsky , David Airlie Cc: Sergey Senozhatsky , Daniel Stone , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: drop drm_property_unreference_blob_locked() In-Reply-To: <1432035516-2909-1-git-send-email-sergey.senozhatsky@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1432035516-2909-1-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Notmuch/0.19+112~g77230b0 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 20 May 2015 10:09:59 +0300 Message-ID: <87wq03k9mg.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 May 2015, Sergey Senozhatsky wrote: > drm_property_unreference_blob_locked() is static and unused, > drop it. http://mid.gmane.org/CAPj87rMPtafeYNzgXoP+fx0dAqhwaD7kdnJgqb_vdbPtiOrXPg@mail.gmail.com > > Signed-off-by: Sergey Senozhatsky > --- > drivers/gpu/drm/drm_crtc.c | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 4059f06..6e60f71 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob) > EXPORT_SYMBOL(drm_property_unreference_blob); > > /** > - * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held > - * > - * Drop a reference on a blob property. May free the object. This must be > - * called with blob_lock held. > - * > - * @param dev Device the blob was created on > - * @param blob Pointer to blob property > - */ > -static void drm_property_unreference_blob_locked(struct drm_property_blob *blob) > -{ > - if (!blob) > - return; > - > - DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(&blob->refcount.refcount)); > - > - kref_put(&blob->refcount, drm_property_free_blob); > -} > - > -/** > * drm_property_reference_blob - Take a reference on an existing property > * > * Take a new reference on an existing blob property. > -- > 2.4.1.168.g1ea28e1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center