Re: [PATCH v12 06/28] module: Do not inline do_init_module

[Rusty Russell <rusty@rustcorp.com.au>]

Jan Kiszka <jan.kiszka@siemens.com> writes:
> This provides a reliable breakpoint target, required for automatic
> symbol loading via the gdb helper command 'lx-symbols'.
>
> CC: Rusty Russell <rusty@rustcorp.com.au>

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks,
Rusty.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  kernel/module.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index d856e96..2df6cec 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3011,8 +3011,13 @@ static void do_free_init(struct rcu_head *head)
>  	kfree(m);
>  }
>  
> -/* This is where the real work happens */
> -static int do_init_module(struct module *mod)
> +/*
> + * This is where the real work happens.
> + *
> + * Keep it uninlined to provide a reliable breakpoint target, e.g. for the gdb
> + * helper command 'lx-symbols'.
> + */
> +static noinline int do_init_module(struct module *mod)
>  {
>  	int ret = 0;
>  	struct mod_initfree *freeinit;
> -- 
> 2.1.4