Re: [PATCH] drm/i915: Audio N value computed for pixel doubled modes

From: Jani Nikula <jani.nikula@linux.intel.com>
To: clinton.a.taylor@intel.com, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Audio N value computed for pixel	doubled modes
Date: Thu, 25 Sep 2014 09:46:06 +0300	[thread overview]
Message-ID: <87wq8surip.fsf@intel.com> (raw)
In-Reply-To: <1411598116-4190-1-git-send-email-clinton.a.taylor@intel.com>

On Thu, 25 Sep 2014, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> HDMI audio clock config was incorrectly choosing the default for
> pixel doubled interlaced modes. The table was missing pixel clock
> values 13.500 (27.000) and 13.513 (27.027). Luckily the default N
> value for 25.200 is the same N value for both 27MHz pixel clocks,
> a warning message was being printed with drm.debug set.
>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 858011d..6625eb5 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7872,6 +7872,8 @@ static struct {
>  	{ 74250, AUD_CONFIG_PIXEL_CLOCK_HDMI_74250 },
>  	{ DIV_ROUND_UP(148500 * 1000, 1001), AUD_CONFIG_PIXEL_CLOCK_HDMI_148352 },
>  	{ 148500, AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 },
> +	{ 13500, AUD_CONFIG_PIXEL_CLOCK_HDMI_27000 },
> +	{ 13513, AUD_CONFIG_PIXEL_CLOCK_HDMI_27027 },

Please use 13500 * 1001 / 1000 instead of 13513 like the rest of the
table.

BR,
Jani.

>  };
>  
>  /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */
> -- 
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center