From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH v3 1/2] virtio-rng: fix stuck of hot-unplugging busy device Date: Thu, 11 Sep 2014 22:20:42 +0930 Message-ID: <87wq9agw2l.fsf@rustcorp.com.au> References: <1410329497-14349-1-git-send-email-akong@redhat.com> <1410329497-14349-2-git-send-email-akong@redhat.com> <20140910070354.GC29832@grmbl.mre> Mime-Version: 1.0 Content-Type: text/plain Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, stable@vger.kernel.org To: Amit Shah , Amos Kong Return-path: In-Reply-To: <20140910070354.GC29832@grmbl.mre> Sender: stable-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Amit Shah writes: > On (Wed) 10 Sep 2014 [14:11:36], Amos Kong wrote: >> When we try to hot-remove a busy virtio-rng device from QEMU monitor, >> the device can't be hot-removed. Because virtio-rng driver hangs at >> wait_for_completion_killable(). >> >> This patch exits the waiting by completing have_data completion before >> unregistering, resets data_avail to avoid the hwrng core use wrong >> buffer bytes. >> >> Signed-off-by: Amos Kong >> Cc: stable@vger.kernel.org > > Reviewed-by: Amit Shah Thanks, applied. Cheers, Rusty.