All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/xbmc: Fix broken variable name
Date: Wed, 27 Aug 2014 23:32:19 +0200	[thread overview]
Message-ID: <87wq9tsjoc.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20140827204942.GA21009@free.fr> (Yann E. MORIN's message of "Wed, 27 Aug 2014 22:49:42 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Bernd, All,
 > On 2014-08-27 22:41 +0200, Bernd Kuhls spake thusly:
 >> BR2_PACKAGE_XBMC_DBUS is provided by package/xbmc/Config.in
 >> 
 >> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 >> ---
 >> package/xbmc/xbmc.mk |    2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)
 >> 
 >> diff --git a/package/xbmc/xbmc.mk b/package/xbmc/xbmc.mk
 >> index bdd634e..0bb6724 100644
 >> --- a/package/xbmc/xbmc.mk
 >> +++ b/package/xbmc/xbmc.mk
 >> @@ -64,7 +64,7 @@ XBMC_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads
 >> LIBS="-lvcos -lvchostif"
 >> endif
 >> 
 >> -ifeq ($(BR2_PACKAGE_DBUS),y)
 >> +ifeq ($(BR2_PACKAGE_XBMC_DBUS),y)
 >> XBMC_DEPENDENCIES += dbus
 >> endif

 > No, because the user can still select the package DBUS directly and
 > since XBMC has no option to disable DBUS, we still want DBUS to be built
 > before XBMC.

 > But granted, this is not obvious from the variable name.

Then we should imho get rid of the XBMC_DBUS option if that option
doesn't do anything.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2014-08-27 21:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 20:41 [Buildroot] [PATCH] package/xbmc: Fix broken variable name Bernd Kuhls
2014-08-27 20:49 ` Yann E. MORIN
2014-08-27 21:11   ` Bernd Kuhls
2014-08-27 21:32   ` Peter Korsgaard [this message]
2014-08-27 21:38     ` Yann E. MORIN
2014-08-28  5:38       ` Bernd Kuhls
2014-08-28  6:54         ` Peter Korsgaard
2014-08-28 10:10         ` Yann E. MORIN
2014-08-28  6:52       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq9tsjoc.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.