From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XHs1T-0006kA-Qt for ath10k@lists.infradead.org; Thu, 14 Aug 2014 10:12:44 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: unregister spectral before mac References: <1407856337-13067-1-git-send-email-sw@simonwunderlich.de> Date: Thu, 14 Aug 2014 13:12:13 +0300 In-Reply-To: <1407856337-13067-1-git-send-email-sw@simonwunderlich.de> (Simon Wunderlich's message of "Tue, 12 Aug 2014 17:12:17 +0200") Message-ID: <87wqabmlc2.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Simon Wunderlich Cc: ath10k@lists.infradead.org Simon Wunderlich writes: > If spectral is unregistered after mac80211, the relayfs file has already > been removed recursively by mac/cfg80211, and spectral tries to remove > the file once more, thus leading to double free problems. Better clean > up spectral before to avoid that problem. > > Reported-by: Kalle Valo > Signed-off-by: Simon Wunderlich Thanks for checking this. But I'm just wondering why even bother to call relay_close() in the first place if mac80211 recursively removes everything anyway? We don't remove any of the debugfs files anyway. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k