From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux
Date: Mon, 17 Mar 2014 16:54:49 +0200 [thread overview]
Message-ID: <87wqfszxhi.fsf@intel.com> (raw)
In-Reply-To: <CABVU7+tVWGZ5ihspC7BKeo=Sc7We=eZz2giC=hVqDUD5g_-pyw@mail.gmail.com>
On Mon, 17 Mar 2014, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> On Mon, Mar 17, 2014 at 11:08 AM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
>> On Fri, Mar 14, 2014 at 11:51 AM, Jani Nikula <jani.nikula@intel.com> wrote:
>>> - if (!intel_dp_aux_native_read(intel_dp, DP_TEST_SINK_MISC, buf, 1))
>>> + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK_MISC, buf) < 0);
>
> wrong ";" here..
Yikes, good catch. I've been rebasing this way too many times...
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-17 14:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 14:51 [PATCH 0/6] drm/i915: switch to drm core dp aux helpers Jani Nikula
2014-03-14 14:51 ` [PATCH 1/6] drm/dp: let drivers specify the name of the I2C-over-AUX adapter Jani Nikula
2014-03-17 14:09 ` Rodrigo Vivi
2014-03-14 14:51 ` [PATCH 2/6] drm/i915/dp: split edp_panel_vdd_on() for reuse Jani Nikula
2014-03-17 14:09 ` Rodrigo Vivi
2014-03-17 14:47 ` Rodrigo Vivi
2014-03-14 14:51 ` [PATCH 3/6] drm/i915/dp: move edp vdd enable/disable at a lower level in i2c-over-aux Jani Nikula
2014-03-17 14:09 ` Rodrigo Vivi
2014-03-14 14:51 ` [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux Jani Nikula
2014-03-17 14:08 ` Rodrigo Vivi
2014-03-17 14:51 ` Rodrigo Vivi
2014-03-17 14:54 ` Jani Nikula [this message]
2014-03-18 10:54 ` Jani Nikula
2014-03-18 14:02 ` Rodrigo Vivi
2014-03-18 14:06 ` Daniel Vetter
2014-03-14 14:51 ` [PATCH 5/6] drm/i915/dp: move dp aux ch register init to aux init Jani Nikula
2014-03-17 14:12 ` Rodrigo Vivi
2014-03-17 14:48 ` Jani Nikula
2014-03-14 14:51 ` [PATCH 6/6] drm/i915/dp: use the new drm helpers for dp i2c-over-aux Jani Nikula
2014-03-17 14:45 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqfszxhi.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.