All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@elte.hu, zheng.z.yan@intel.com, bp@alien8.de
Subject: Re: [PATCH] perf/x86/uncore: fix missing end markers for SNB/IVB/HSW IMC PMU
Date: Thu, 13 Mar 2014 10:17:07 -0700	[thread overview]
Message-ID: <87wqfyf27g.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <20140313120436.GA14236@quad> (Stephane Eranian's message of "Thu, 13 Mar 2014 13:04:36 +0100")

Stephane Eranian <eranian@google.com> writes:

> This patch fixes a bug with the SNB/IVB/HSW uncore
> mmeory controller support.
>
> The PCI Ids tables for the memory controller were missing end markers.
> That could cause random crashes on boot during or after PCI device
> registration.

I wonder if there's a way to check this in checkpatch.pl ?

Or maybe a sparse check could be added, with a new type attribute 
that says "needs to be 0 terminate"

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2014-03-13 17:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 12:04 [PATCH] perf/x86/uncore: fix missing end markers for SNB/IVB/HSW IMC PMU Stephane Eranian
2014-03-13 17:17 ` Andi Kleen [this message]
2014-03-13 19:35   ` Stephane Eranian
2014-03-14  8:39 ` [tip:perf/core] perf/x86/uncore: Fix missing end markers for SNB/ IVB/HSW " tip-bot for Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqfyf27g.fsf@tassilo.jf.intel.com \
    --to=andi@firstfloor.org \
    --cc=bp@alien8.de \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=zheng.z.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.