From: Thomas Rast <trast@inf.ethz.ch>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>, Johannes Sixt <j6t@kdbg.org>,
Jonathan Nieder <jrnieder@gmail.com>,
"John J. Franey" <jjfraney@gmail.com>
Subject: Re: [PATCH] run-command: simplify wait_or_whine
Date: Sat, 1 Jun 2013 16:19:22 +0200 [thread overview]
Message-ID: <87wqqdoqvp.fsf@hexa.v.cablecom.net> (raw)
In-Reply-To: <1370094715-2684-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Sat, 1 Jun 2013 08:51:55 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Nobody is checking for specific error codes; it's the errno that's
> important.
[...]
> - /*
> - * This return value is chosen so that code & 0xff
> - * mimics the exit code that a POSIX shell would report for
> - * a program that died from this signal.
> - */
> - code += 128;
Have you checked the callers? There are lots of callers of
finish_command(), which returns the value from wait_or_whine()
unmodified.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-06-01 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 13:51 [PATCH] run-command: simplify wait_or_whine Felipe Contreras
2013-06-01 14:03 ` Duy Nguyen
2013-06-01 14:06 ` Felipe Contreras
2013-06-01 14:08 ` Duy Nguyen
2013-06-01 14:20 ` Felipe Contreras
2013-06-01 14:19 ` Thomas Rast [this message]
2013-06-01 14:23 ` Felipe Contreras
2013-06-01 14:21 ` Duy Nguyen
2013-06-01 14:30 ` Felipe Contreras
2013-06-01 14:36 ` Duy Nguyen
2013-06-01 15:01 ` Felipe Contreras
2013-06-01 17:24 ` [PATCH] t0005: test git exit code from signal death Jeff King
2013-06-01 21:41 ` Felipe Contreras
2013-06-01 17:01 ` [PATCH] run-command: simplify wait_or_whine Jeff King
2013-06-01 21:35 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqqdoqvp.fsf@hexa.v.cablecom.net \
--to=trast@inf.ethz.ch \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jjfraney@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.