From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal Date: Wed, 12 Dec 2012 10:31:04 +1030 Message-ID: <87wqwo3zr3.fsf@rustcorp.com.au> References: <029d7029bc1186fbd2ec74123dc88922b9600660.1352366215.git.amit.shah@redhat.com> <87ip96id3a.fsf@rustcorp.com.au> <20121210055401.GA17187@amit.redhat.com> <871uexec7e.fsf@rustcorp.com.au> <20121211041012.GA16297@amit.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20121211041012.GA16297@amit.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah Cc: "Michael S. Tsirkin" , sjur@brendeland.net, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, masami.hiramatsu.pt@hitachi.com, Sjur =?utf-8?Q?Br=C3=A6ndeland?= List-Id: virtualization@lists.linuxfoundation.org QW1pdCBTaGFoIDxhbWl0LnNoYWhAcmVkaGF0LmNvbT4gd3JpdGVzOgoKPiBPbiAoVHVlKSAxMSBE ZWMgMjAxMiBbMDk6Mzk6NDFdLCBSdXN0eSBSdXNzZWxsIHdyb3RlOgo+PiBBbWl0IFNoYWggPGFt aXQuc2hhaEByZWRoYXQuY29tPiB3cml0ZXM6Cj4+IAo+PiA+IE9uIChGcmkpIDE2IE5vdiAyMDEy IFsxMToyMjowOV0sIFJ1c3R5IFJ1c3NlbGwgd3JvdGU6Cj4+ID4+IEFtaXQgU2hhaCA8YW1pdC5z aGFoQHJlZGhhdC5jb20+IHdyaXRlczoKPj4gPj4gPiBGcm9tOiBTanVyIEJyw6ZuZGVsYW5kIDxz anVyLmJyYW5kZWxhbmRAc3Rlcmljc3Nvbi5jb20+Cj4+ID4+ID4KPj4gPj4gPiBSZW1vdmUgYnVm ZmVycyBmcm9tIHRoZSBvdXQtcXVldWUgd2hlbiBhIHBvcnQgaXMgcmVtb3ZlZC4gUnByb2Nfc2Vy aWFsCj4+ID4+ID4gY29tbXVuaWNhdGVzIHdpdGggcmVtb3RlIHByb2Nlc3NvcnMgdGhhdCBtYXkg Y3Jhc2ggYW5kIGxlYXZlIGJ1ZmZlcnMgaW4KPj4gPj4gPiB0aGUgb3V0LXF1ZXVlLiBUaGUgdmly dGlvIHNlcmlhbCBwb3J0cyBtYXkgaGF2ZSBidWZmZXJzIGluIHRoZSBvdXQtcXVldWUKPj4gPj4g PiBhcyB3ZWxsLCBlLmcuIGZvciBub24tYmxvY2tpbmcgcG9ydHMgYW5kIHRoZSBob3N0IGRpZG4n dCBjb25zdW1lIHRoZW0KPj4gPj4gPiB5ZXQuCj4+ID4+ID4KPj4gPj4gPiBbQW1pdDogUmVtb3Zl IFdBUk5fT04gZm9yIGdlbmVyaWMgcG9ydHMgY2FzZS5dCj4+ID4+ID4KPj4gPj4gPiBTaWduZWQt b2ZmLWJ5OiBTanVyIEJyw6ZuZGVsYW5kIDxzanVyLmJyYW5kZWxhbmRAc3Rlcmljc3Nvbi5jb20+ Cj4+ID4+ID4gU2lnbmVkLW9mZi1ieTogQW1pdCBTaGFoIDxhbWl0LnNoYWhAcmVkaGF0LmNvbT4K Pj4gPj4gCj4+ID4+IEkgYWxyZWFkeSBoYXZlIHRoaXMgaW4gbXkgcGVuZGluZyBxdWV1ZTsgSSd2 ZSBwcm9tb3RlZCBpdCB0byBteQo+PiA+PiB2aXJ0aW8tbmV4dCBicmFuY2ggbm93Lgo+PiA+Cj4+ ID4gUnVzdHksIEkgc3RpbGwgc2VlIHRoaXMgc2VyaWVzIGluIHlvdXIgcGVuZGluZyBxdWV1ZSwg bm90IGluCj4+ID4gdmlydGlvLW5leHQuICBEaWQgYW55dGhpbmcgY2hhbmdlIGluIHRoZSBtZWFu dGltZT8KPj4gCj4+IEhtbToKPj4gCj4+IDQwZTYyNWFjNTBmNDBkODdkZGJhOTMyODBkMGE1MDM0 MjVhYTY4ZTk/Cj4KPiBJJ20gc29ycnksIEkgbWVhbnQgdGhlIHJlbW90ZXByb2MgY29kZSwgbm90 IHRoaXMgcGF0Y2guCgpTdGlsbCB3YWl0aW5nIGZvciB2OSwgQUZJQUNUPwoKU2p1ciwgd2UncmUg aW4gdGhlIG1lcmdlIHdpbmRvdyBub3csIHNvIGl0J2QgYmUgbmljZSB0byBnZXQgeW91ciBsYXRl c3QKdmVyc2lvbiBvbiB0b3Agb2YgbGludXgtbmV4dCAob3Igc2ltcGx5IG15IHZpcnRpby1uZXh0 IGdpdCB0cmVlKSB0b2RheS4KClRoYW5rcywKUnVzdHkuCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0 dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4 Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262Ab2LLADo (ORCPT ); Tue, 11 Dec 2012 19:03:44 -0500 Received: from ozlabs.org ([203.10.76.45]:55408 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754392Ab2LLADm convert rfc822-to-8bit (ORCPT ); Tue, 11 Dec 2012 19:03:42 -0500 From: Rusty Russell To: Amit Shah Cc: sjur@brendeland.net, "Michael S. Tsirkin" , linus.walleij@linaro.org, masami.hiramatsu.pt@hitachi.com, ohad@wizery.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Sjur =?utf-8?Q?Br=C3=A6ndeland?= Subject: Re: [[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal In-Reply-To: <20121211041012.GA16297@amit.redhat.com> References: <029d7029bc1186fbd2ec74123dc88922b9600660.1352366215.git.amit.shah@redhat.com> <87ip96id3a.fsf@rustcorp.com.au> <20121210055401.GA17187@amit.redhat.com> <871uexec7e.fsf@rustcorp.com.au> <20121211041012.GA16297@amit.redhat.com> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Wed, 12 Dec 2012 10:31:04 +1030 Message-ID: <87wqwo3zr3.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Amit Shah writes: > On (Tue) 11 Dec 2012 [09:39:41], Rusty Russell wrote: >> Amit Shah writes: >> >> > On (Fri) 16 Nov 2012 [11:22:09], Rusty Russell wrote: >> >> Amit Shah writes: >> >> > From: Sjur Brændeland >> >> > >> >> > Remove buffers from the out-queue when a port is removed. Rproc_serial >> >> > communicates with remote processors that may crash and leave buffers in >> >> > the out-queue. The virtio serial ports may have buffers in the out-queue >> >> > as well, e.g. for non-blocking ports and the host didn't consume them >> >> > yet. >> >> > >> >> > [Amit: Remove WARN_ON for generic ports case.] >> >> > >> >> > Signed-off-by: Sjur Brændeland >> >> > Signed-off-by: Amit Shah >> >> >> >> I already have this in my pending queue; I've promoted it to my >> >> virtio-next branch now. >> > >> > Rusty, I still see this series in your pending queue, not in >> > virtio-next. Did anything change in the meantime? >> >> Hmm: >> >> 40e625ac50f40d87ddba93280d0a503425aa68e9? > > I'm sorry, I meant the remoteproc code, not this patch. Still waiting for v9, AFIACT? Sjur, we're in the merge window now, so it'd be nice to get your latest version on top of linux-next (or simply my virtio-next git tree) today. Thanks, Rusty.