From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTHMv-00025x-L2 for qemu-devel@nongnu.org; Tue, 30 Oct 2012 15:21:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTHMu-0005Jl-0Z for qemu-devel@nongnu.org; Tue, 30 Oct 2012 15:20:57 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:34399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTHMt-0005Hy-DU for qemu-devel@nongnu.org; Tue, 30 Oct 2012 15:20:55 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 31 Oct 2012 00:50:52 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9UJKmb060227730 for ; Wed, 31 Oct 2012 00:50:48 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9V0odFw021792 for ; Wed, 31 Oct 2012 11:50:39 +1100 From: Anthony Liguori In-Reply-To: References: Date: Tue, 30 Oct 2012 14:20:35 -0500 Message-ID: <87wqy7u5q4.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v1 00/13] q35 patches for pci tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron , qemu-devel@nongnu.org Cc: juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, agraf@suse.de, armbru@redhat.com, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, kraxel@redhat.com Jason Baron writes: > Hi, > > Re-base of my previous q35 patches on top of Michael Tsirkin's pci > tree. I don't want this to come in through the pci tree. This is not just another PCI device and the ramifications are pretty big since this will become the main machine model. > Qemu bits for q35 support, I'm posting the seabios changes separately. The > patches require '-M q35' and -L 'seabios dir with q35 changes' on the > qemu command line. Hopefully, we can make it the default for x86 at some future > point when we feel comfortable with it. I'm hoping these patches can be > included for the 1.3 soft freeze. Q35 is sufficiently important that I think we should push for it in 1.3 regardless of freeze dates. The code is pretty close to being ready. So let's not worry too much about merge dates and focusing on getting the code up to the right level. > The current patches have been tested with basic install testing and memory testing > on f16, f17, windows 7 and windows 8. They can be run on the various BSD flavors > by adding a 'piix4-ide' device to the pci bus. ie: -device piix4-ide. Patches > have also been reported to work with a small dsdt change on OSX 10.6 as well. > > I've also dropped ACPI hotplug support completely - I simply haven't gotten a > chance to clean this up yet. Hopefully, it is ok for this to come in a bit > later. > > Git trees: > > git://github.com/jibaron/q35-qemu.git > git://github.com/jibaron/q35-seabios.git > > Major Todo Items: > > -add ahci migration back (need to cover more fields, but basically works) > -add ACPI hotplug support (pcie hotplug is currently working) Since this is coming in as experimental for 1.3, I'm not overly concerned about missing functionality. I'm more concerned with code structure and device modeling so let's focus on getting this right for 1.3. Overall, the series looks pretty nice. Thanks for all of your work here! Regards, Anthony Liguori > > > Isaku Yamahata (3): > pc/piix_pci: factor out smram/pam logic > pc, pc_piix: split out pc nic initialization > q35: Introduce q35 pc based chipset emulator > > Jan Kiszka (2): > q35: Suppress SMM BIOS initialization under KVM > q35: Add kvmclock support > > Jason Baron (8): > Back out add of i21154 > blockdev: Introduce QEMUMachine->default_drive_if > blockdev: Introduce IF_AHCI > pc: Move ioapic_init() from pc_piix.c to pc.c > Add a fallback bios file search, if -L fails. > q35: automatically load the q35 dsdt table > q35: fill in usb pci slots with -usb > Fixup q35/ich9 Licenses > > blockdev.c | 23 +++- > blockdev.h | 22 +++ > hw/Makefile.objs | 2 +- > hw/acpi_ich9.c | 20 ++- > hw/boards.h | 2 +- > hw/device-hotplug.c | 2 +- > hw/highbank.c | 2 +- > hw/i21154.c | 113 ---------------- > hw/i21154.h | 9 -- > hw/i386/Makefile.objs | 3 +- > hw/ich9.h | 5 +- > hw/ide.h | 1 + > hw/ide/core.c | 9 ++ > hw/ide/pci.c | 19 +++ > hw/ide/pci.h | 1 + > hw/leon3.c | 1 - > hw/lpc_ich9.c | 32 +---- > hw/mips_jazz.c | 4 +- > hw/pam.c | 87 ++++++++++++ > hw/pam.h | 97 ++++++++++++++ > hw/pc.c | 58 ++++++++ > hw/pc.h | 7 + > hw/pc_piix.c | 38 +----- > hw/pc_q35.c | 354 +++++++++++++++++++++++++++++++++++++++++++++++++ > hw/pc_sysfw.c | 2 +- > hw/pci_ids.h | 2 + > hw/piix_pci.c | 68 ++-------- > hw/puv3.c | 1 - > hw/q35.c | 315 +++++++++++++++++++++++++++++++++++++++++++ > hw/q35.h | 161 ++++++++++++++++++++++ > hw/realview.c | 6 +- > hw/smbus_ich9.c | 14 +- > hw/spapr.c | 2 +- > hw/sun4m.c | 24 ++-- > hw/versatilepb.c | 4 +- > hw/vexpress.c | 4 +- > hw/xilinx_zynq.c | 2 +- > vl.c | 56 +++++--- > 38 files changed, 1272 insertions(+), 300 deletions(-) > delete mode 100644 hw/i21154.c > delete mode 100644 hw/i21154.h > create mode 100644 hw/pam.c > create mode 100644 hw/pam.h > create mode 100644 hw/pc_q35.c > create mode 100644 hw/q35.c > create mode 100644 hw/q35.h