From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com From: ebiederm@xmission.com (Eric W. Biederman) References: <1344000593-18794-1-git-send-email-richard@nod.at> Date: Fri, 03 Aug 2012 07:19:55 -0700 In-Reply-To: <1344000593-18794-1-git-send-email-richard@nod.at> (Richard Weinberger's message of "Fri, 3 Aug 2012 15:29:53 +0200") Message-ID: <87wr1gm510.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: [kernel-hardening] Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated" To: Richard Weinberger Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dvhart@linux.intel.com, paul.gortmaker@windriver.com, jkosina@suse.cz, rob@landley.net, Randy Dunlap , Peter Zijlstra , David Howells , "Serge E. Hallyn" , kernel-hardening@lists.openwall.com, spender@grsecurity.net, keescook@chromium.org, tglx@linutronix.de, Cyrill Gorcunov , xemul@parallels.com, stable@vger.kernel.org List-ID: Richard Weinberger writes: > get_robust_list has at least two valid use cases. > 1. checkpoint/restore in userspace > 2. post mortem analysis Looks good to me. Acked-by: "Eric W. Biederman" > > Cc: Randy Dunlap > Cc: Darren Hart > Cc: Peter Zijlstra > Cc: Jiri Kosina > Cc: Eric W. Biederman > Cc: David Howells > Cc: Serge E. Hallyn > Cc: kernel-hardening@lists.openwall.com > Cc: spender@grsecurity.net > Cc: keescook@chromium.org > Cc: tglx@linutronix.de > Cc: Cyrill Gorcunov > Cc: xemul@parallels.com > Cc: # 3.4.x > Cc: # 3.5.x > Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr= 1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com > Signed-off-by: Richard Weinberger > --- > Documentation/feature-removal-schedule.txt | 10 ---------- > kernel/futex.c | 2 -- > kernel/futex_compat.c | 2 -- > 3 Dateien ge=C3=A4ndert, 14 Zeilen entfernt(-) > > diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/f= eature-removal-schedule.txt > index afaff31..a25482e 100644 > --- a/Documentation/feature-removal-schedule.txt > +++ b/Documentation/feature-removal-schedule.txt > @@ -506,16 +506,6 @@ Who: Sebastian Andrzej Siewior >=20=20 > ---------------------------- >=20=20 > -What: get_robust_list syscall > -When: 2013 > -Why: There appear to be no production users of the get_robust_list sysca= ll, > - and it runs the risk of leaking address locations, allowing the bypass > - of ASLR. It was only ever intended for debugging, so it should be > - removed. > -Who: Kees Cook > - > ----------------------------- > - > What: Removing the pn544 raw driver. > When: 3.6 > Why: With the introduction of the NFC HCI and SHDL kernel layers, pn544.c > diff --git a/kernel/futex.c b/kernel/futex.c > index e2b0fb9..d701be5 100644 > --- a/kernel/futex.c > +++ b/kernel/futex.c > @@ -2449,8 +2449,6 @@ SYSCALL_DEFINE3(get_robust_list, int, pid, > if (!futex_cmpxchg_enabled) > return -ENOSYS; >=20=20 > - WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n"); > - > rcu_read_lock(); >=20=20 > ret =3D -ESRCH; > diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c > index 83e368b..a9642d5 100644 > --- a/kernel/futex_compat.c > +++ b/kernel/futex_compat.c > @@ -142,8 +142,6 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __u= ser *head_ptr, > if (!futex_cmpxchg_enabled) > return -ENOSYS; >=20=20 > - WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n"); > - > rcu_read_lock(); >=20=20 > ret =3D -ESRCH;