From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH] net: sierra_net: device IDs for Aircard 320U++ Date: Wed, 06 Jun 2012 10:19:15 +0200 Message-ID: <87wr3kua2k.fsf@nemi.mork.no> References: <20120605212414.GB6526@kroah.com> <1338967090-7119-1-git-send-email-bjorn@mork.no> <20120606081246.GB7306@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dan Williams , linux-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org, Autif Khan , Tom Cassidy , stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH Return-path: In-Reply-To: <20120606081246.GB7306-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> (Greg KH's message of "Wed, 6 Jun 2012 17:12:46 +0900") Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Greg KH writes: > On Wed, Jun 06, 2012 at 09:18:10AM +0200, Bj=C3=B8rn Mork wrote: >> Adding device IDs for Aircard 320U and two other devices >> found in the out-of-tree version of this driver. >>=20 >> Cc: linux-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org >> Cc: Autif Khan >> Cc: Tom Cassidy >> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Signed-off-by: Bj=C3=B8rn Mork >> --- >> drivers/net/usb/sierra_net.c | 14 ++++++++++---- >> 1 file changed, 10 insertions(+), 4 deletions(-) > > Wait, Tom just sent me a patch adding these device ids to the sierra > serial driver, why would the same device work for both drivers? Because it's a composite device. Was this a trick question? :-) > Where should the device id go? To both drivers. The device is similar to the 1199:68a3 device already supported by both drivers. It has a number of serial ports (depending on how many features like GPS etc is enabled) supported by the "sierra" driver and one ethernet interface speaking Sierra's HIP protocol supported by the "sierra_net" driver. Bj=C3=B8rn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html